Skip to content

Commit 26c2476

Browse files
committed
Address skipped tests
1 parent d0fc1f8 commit 26c2476

File tree

1 file changed

+5
-21
lines changed

1 file changed

+5
-21
lines changed

test/Rx/Observable/GroupedObservableTest.php

+5-21
Original file line numberDiff line numberDiff line change
@@ -14,34 +14,18 @@ class GroupedObservableTest extends TestCase
1414
*/
1515
public function it_returns_the_disposable_of_the_underlying_disposable()
1616
{
17-
$this->markTestSkipped("Disposable is now wrapped by AnonymousObservable. Find other way to test?");
1817
$disposable = $this->getMock('Rx\DisposableInterface');
18+
19+
$disposable->expects($this->once())
20+
->method('dispose');
21+
1922
$observable = new AnonymousObservable(function() use (&$disposable) {
2023
return $disposable;
2124
});
2225

2326
$groupedObservable = new GroupedObservable('key', $observable);
2427

25-
$this->assertEquals($disposable, $groupedObservable->subscribe(new CallbackObserver()));
26-
}
27-
28-
/**
29-
* @test
30-
*/
31-
public function it_returns_a_composite_disposable_with_the_given_merged_disposable()
32-
{
33-
$this->markTestSkipped("Disposable is now wrapped by AnonymousObservable. Find other way to test?");
34-
$d1 = $this->getMock('Rx\DisposableInterface');
35-
$d2 = new RefCountDisposable($d1);
36-
37-
$observable = new AnonymousObservable(function() use (&$d1) {
38-
return $d1;
39-
});
40-
41-
$groupedObservable = new GroupedObservable('key', $observable, $d2);
42-
43-
$disposable = $groupedObservable->subscribe(new CallbackObserver());
44-
$this->assertInstanceOf('Rx\Disposable\CompositeDisposable', $disposable);
28+
$groupedObservable->subscribe(new CallbackObserver())->dispose();
4529
}
4630

4731
/**

0 commit comments

Comments
 (0)