Skip to content

Commit 9804de7

Browse files
authored
fix(Subject): lift signature is now appropriate for stricter TypeScript 2.4 checks (#2722)
Type safety wasn't really gauranteed with lift before because we survived for a long time with an incorrect type signature, TypeScript 2.4 introduces stricter type-checking, and all of a sudden `lift` on `Subject` was breaking builds for those that are riding the wave of the latest-and-greatest.
1 parent 3bb6240 commit 9804de7

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/Subject.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ export class Subject<T> extends Observable<T> implements ISubscription {
4343
return new AnonymousSubject<T>(destination, source);
4444
}
4545

46-
lift<R>(operator: Operator<T, R>): Observable<T> {
46+
lift<R>(operator: Operator<T, R>): Observable<R> {
4747
const subject = new AnonymousSubject(this, this);
4848
subject.operator = <any>operator;
4949
return <any>subject;

0 commit comments

Comments
 (0)