From f517ac53accde5ab08ecf31e5249571645b7d23c Mon Sep 17 00:00:00 2001 From: DvirDukhan Date: Wed, 27 May 2020 14:46:57 +0300 Subject: [PATCH 1/3] escape strings --- src/graph.js | 3 ++- test/redisGraphAPITest.js | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/graph.js b/src/graph.js index 1fcec75b4f..b96aa29241 100644 --- a/src/graph.js +++ b/src/graph.js @@ -62,7 +62,8 @@ class Graph { if (paramValue == null) return "null"; let paramType = typeof paramValue; if (paramType == "string") { - let strValue = ""; + let strValue = ""; + paramValue = paramValue.replace(/[\\"']/g, '\\$&'); if (paramValue[0] != '"') strValue += '"'; strValue += paramValue; if (paramValue[paramValue.length - 1] != '"') strValue += '"'; diff --git a/test/redisGraphAPITest.js b/test/redisGraphAPITest.js index 371d3a7f75..ba5d2b9af4 100644 --- a/test/redisGraphAPITest.js +++ b/test/redisGraphAPITest.js @@ -411,7 +411,8 @@ describe("RedisGraphAPI Test", () => { "str", [1, 2, 3], ["1", "2", "3"], - null, + null, + 'test"abc' ]; let promises = []; for (var i = 0; i < params.length; i++) { From 8a5ddcdb726683a2a4ab12ff498011ff4e3a9812 Mon Sep 17 00:00:00 2001 From: Guy Korland Date: Wed, 27 May 2020 15:00:14 +0300 Subject: [PATCH 2/3] Update graph.js --- src/graph.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/graph.js b/src/graph.js index b96aa29241..7d82838d4c 100644 --- a/src/graph.js +++ b/src/graph.js @@ -62,8 +62,8 @@ class Graph { if (paramValue == null) return "null"; let paramType = typeof paramValue; if (paramType == "string") { - let strValue = ""; - paramValue = paramValue.replace(/[\\"']/g, '\\$&'); + let strValue = ""; + paramValue = paramValue.replace(/[\\"']/g, '\\$&'); if (paramValue[0] != '"') strValue += '"'; strValue += paramValue; if (paramValue[paramValue.length - 1] != '"') strValue += '"'; From d299b6ae509becf1b829d6d986bcfca741008a5f Mon Sep 17 00:00:00 2001 From: Guy Korland Date: Wed, 27 May 2020 15:01:00 +0300 Subject: [PATCH 3/3] Update redisGraphAPITest.js --- test/redisGraphAPITest.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/redisGraphAPITest.js b/test/redisGraphAPITest.js index ba5d2b9af4..22a8095f4b 100644 --- a/test/redisGraphAPITest.js +++ b/test/redisGraphAPITest.js @@ -411,8 +411,8 @@ describe("RedisGraphAPI Test", () => { "str", [1, 2, 3], ["1", "2", "3"], - null, - 'test"abc' + null, + 'test"abc' ]; let promises = []; for (var i = 0; i < params.length; i++) {