Added new timeProvider property to a logger: PR fix:

- Made it none optional.

Author: sshirokov-mwb

Log4swift/Logger.swift

@@ -44,13 +44,13 @@ A logger is identified by a UTI identifier, it defines a threshold level and a d
 
   /// The UTI string that identifies the logger. Example : product.module.feature
   public let identifier: String
-  
+
   internal var parent: Logger?
 
   private var thresholdLevelStorage: LogLevel
   private var appendersStorage: [Appender]
   private var asynchronousStorage = false
-  private var timeProviderStorage: (() -> Date)?
+  private var timeProviderStorage: () -> Date = Date.init
 
   /// If asynchronous is true, only the minimum of work will be done on the main thread, the rest will be deffered to a low priority background thread.
   /// The order of the messages will be preserved in async mode.
@@ -105,7 +105,7 @@ A logger is identified by a UTI identifier, it defines a threshold level and a d
   }
 
   /// Gets/sets external time provider for log messages.
-  /// If `nil` then default behavior `Date()` will be used.
+  /// Default behavior is just `Date()`.
   ///
   /// Allows to "mock" the time - could be useful in unit tests
   /// which may run on some "virtual" time instead of real one.
@@ -114,7 +114,7 @@ A logger is identified by a UTI identifier, it defines a threshold level and a d
   /// (on the `rootLogger` for example) - entire sub-hierarchy of loggers will have it.
   ///
   @objc
-  public var timeProvider: (() -> Date)? {
+  public var timeProvider: () -> Date {
     get {
       if let parent = self.parent {
         return parent.timeProvider
@@ -260,7 +260,7 @@ A logger is identified by a UTI identifier, it defines a threshold level and a d
       var info: LogInfoDictionary = [
         .LoggerName: self.identifier,
         .LogLevel: level,
-        .Timestamp: (self.timeProvider?() ?? Date()).timeIntervalSince1970,
+        .Timestamp: self.timeProvider().timeIntervalSince1970,
         .ThreadId: currentThreadId(),
         .ThreadName: currentThreadName()
       ]
@@ -289,7 +289,7 @@ A logger is identified by a UTI identifier, it defines a threshold level and a d
       var info: LogInfoDictionary = [
         .LoggerName: self.identifier,
         .LogLevel: level,
-        .Timestamp: (self.timeProvider?() ?? Date()).timeIntervalSince1970,
+        .Timestamp: self.timeProvider().timeIntervalSince1970,
         .ThreadId: currentThreadId(),
         .ThreadName: currentThreadName()
       ]

Log4swiftTests/LoggerTests.swift

@@ -548,7 +548,7 @@ class LoggerTests: XCTestCase {
     parentLogger.timeProvider = { return testDate }
 
     // Validate
-    XCTAssertEqual(sonLogger.timeProvider?(), testDate)
+    XCTAssertEqual(sonLogger.timeProvider(), testDate)
   }
 
   func testChangingSonLoggerParameterBreakLinkWithParent() {
@@ -605,8 +605,8 @@ class LoggerTests: XCTestCase {
 
     // Validate
     XCTAssertNil(sonLogger.parent)
-    XCTAssertEqual(parentLogger.timeProvider?(), testDate.0)
-    XCTAssertEqual(sonLogger.timeProvider?(), testDate.1)
+    XCTAssertEqual(parentLogger.timeProvider(), testDate.0)
+    XCTAssertEqual(sonLogger.timeProvider(), testDate.1)
   }
 
   func testLoggedTimeIsTakenWhenLogIsRequested() {