Skip to content

Commit 41a4d7c

Browse files
authored
refactor: remove 'hooks-extra/prefer-use-state-lazy-initialization' from recommended presets (#1001)
1 parent 1e9d298 commit 41a4d7c

File tree

5 files changed

+2
-9
lines changed

5 files changed

+2
-9
lines changed

apps/website/content/docs/rules/overview.mdx

+1-1
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ Linter rules can have false positives, false negatives, and some rules are depen
116116
| [`no-unnecessary-use-callback`](./hooks-extra-no-unnecessary-use-callback) | 0️⃣ | Disallow unnecessary usage of `useCallback`. |
117117
| [`no-unnecessary-use-memo`](./hooks-extra-no-unnecessary-use-memo) | 0️⃣ | Disallow unnecessary usage of `useMemo`. |
118118
| [`no-unnecessary-use-prefix`](./hooks-extra-no-unnecessary-use-prefix) | 1️⃣ | Enforces custom Hooks to use at least one other Hook inside. |
119-
| [`prefer-use-state-lazy-initialization`](./hooks-extra-prefer-use-state-lazy-initialization) | 1️⃣ | Enforces function calls made inside `useState` to be wrapped in an `initializer function`. |
119+
| [`prefer-use-state-lazy-initialization`](./hooks-extra-prefer-use-state-lazy-initialization) | 0️⃣ | Enforces function calls made inside `useState` to be wrapped in an `initializer function`. |
120120

121121
## Naming Convention Rules
122122

packages/plugins/eslint-plugin-react-hooks-extra/src/configs/recommended.ts

-1
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,4 @@ export const name = "react-hooks-extra/recommended";
55
export const rules = {
66
"react-hooks-extra/no-direct-set-state-in-use-effect": "warn",
77
"react-hooks-extra/no-unnecessary-use-prefix": "warn",
8-
"react-hooks-extra/prefer-use-state-lazy-initialization": "warn",
98
} as const satisfies RulePreset;

packages/plugins/eslint-plugin-react-hooks-extra/src/rules/prefer-use-state-lazy-initialization.md

-6
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,6 @@ react-hooks-extra/prefer-use-state-lazy-initialization
1414
@eslint-react/hooks-extra/prefer-use-state-lazy-initialization
1515
```
1616

17-
**Presets**
18-
19-
- `recommended`
20-
- `recommended-typescript`
21-
- `recommended-type-checked`
22-
2317
## Description
2418

2519
Enforces function calls made inside `useState` to be wrapped in an `initializer function`.

packages/plugins/eslint-plugin-react-hooks-extra/src/rules/prefer-use-state-lazy-initialization.ts

+1
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ function isAllowedName(name: string): boolean {
2626
}
2727

2828
// rule takes inspiration from https://github.com/facebook/react/issues/26520
29+
// TODO: Deprecate this rule when React Compiler is stable enough to be used in production https://github.com/facebook/react/issues/26520#issuecomment-2140795892
2930
export default createRule<[], MessageID>({
3031
meta: {
3132
type: "problem",

packages/plugins/eslint-plugin/src/configs/recommended.ts

-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ export const rules = {
1515
...webApi.rules,
1616
"@eslint-react/hooks-extra/no-direct-set-state-in-use-effect": "warn",
1717
"@eslint-react/hooks-extra/no-unnecessary-use-prefix": "warn",
18-
"@eslint-react/hooks-extra/prefer-use-state-lazy-initialization": "warn",
1918
} as const satisfies RulePreset;
2019

2120
export const plugins = {

0 commit comments

Comments
 (0)