fix: correct readonly checks and test cases (#957)

Author: Rel1cx

packages/plugins/eslint-plugin-react-x/package.json

@@ -59,7 +59,6 @@
     "@typescript-eslint/types": "^8.25.0",
     "@typescript-eslint/utils": "^8.25.0",
     "compare-versions": "^6.1.1",
-    "is-immutable-type": "^5.0.1",
     "string-ts": "^2.2.1",
     "ts-pattern": "^5.6.2"
   },

packages/plugins/eslint-plugin-react-x/src/rules/prefer-read-only-props.spec.ts

@@ -529,9 +529,9 @@ ruleTesterWithTypes.run(RULE_NAME, rule, {
       import * as React from "react";
 
       interface HSV {
-        h: number;
-        s: number;
-        v: number;
+        readonly h: number;
+        readonly s: number;
+        readonly v: number;
       }
       interface ValuePickerProps {
         readonly Disabled: boolean;
@@ -542,27 +542,6 @@ ruleTesterWithTypes.run(RULE_NAME, rule, {
         return <div />
       }
     `,
-    /* tsx */ `
-      /// <reference types="react" />
-      /// <reference types="react-dom" />
-
-      import * as React from "react";
-
-      interface HSV {
-        h: number;
-        s: number;
-        v: number;
-      }
-      interface ValuePickerProps {
-        readonly Disabled: boolean;
-        readonly Hsv: HSV
-        // TODO: Support checking if function is readonly
-        onChange: () => void;
-      }
-      export function ValuePicker({ Disabled, Hsv, onChange }: ValuePickerProps) {
-        return <div />
-      }
-    `,
     // memo with generic
     /* tsx */ `
       /// <reference types="react" />

packages/plugins/eslint-plugin-react-x/src/rules/prefer-read-only-props.ts

@@ -3,7 +3,6 @@ import type { RuleFeature } from "@eslint-react/shared";
 import { getConstrainedTypeAtLocation, isTypeReadonly } from "@typescript-eslint/type-utils";
 import type { ParserServicesWithTypeInformation } from "@typescript-eslint/utils";
 import { ESLintUtils } from "@typescript-eslint/utils";
-import { getTypeImmutability, isImmutable, isReadonlyDeep, isReadonlyShallow, isUnknown } from "is-immutable-type";
 import type { CamelCase } from "string-ts";
 import type ts from "typescript";
 
@@ -18,15 +17,6 @@ export const RULE_FEATURES = [
 
 export type MessageID = CamelCase<typeof RULE_NAME>;
 
-function isReadonlyType(type: ts.Type, services: ParserServicesWithTypeInformation): boolean {
-  try {
-    const im = getTypeImmutability(services.program, type);
-    return isUnknown(im) || isImmutable(im) || isReadonlyShallow(im) || isReadonlyDeep(im);
-  } catch {
-    return true;
-  }
-}
-
 export default createRule<[], MessageID>({
   meta: {
     type: "problem",
@@ -53,7 +43,7 @@ export default createRule<[], MessageID>({
             continue;
           }
           const propsType = getConstrainedTypeAtLocation(services, props);
-          if (isTypeReadonly(services.program, propsType) || isReadonlyType(propsType, services)) {
+          if (isTypeReadonly(services.program, propsType)) {
             continue;
           }
           context.report({ messageId: "preferReadOnlyProps", node: props });