fix(instrumentation/https): add https instrumentation

Author: Peter Marton

README.md

@@ -75,7 +75,7 @@ Create a new Tracer and instrument modules.
 
 ## Instrumentations
 
-- [http](https://nodejs.org/api/http.html)
+- [http, https](https://nodejs.org/api/http.html)
 - [express](https://expressjs.com/)
 - [MongoDB](https://www.npmjs.com/package/mongodb-core)
 - [PostgreSQL](https://www.npmjs.com/package/pg)

src/instrumentation/httpClient.js

@@ -67,7 +67,7 @@ function patchHttp (http, tracer) {
           _.isUndefined
         )
 
-        if (res.statusCode >= 400) {
+        if (res.statusCode > 399) {
           span.setTag(opentracing.Tags.ERROR, true)
         }
 

src/instrumentation/httpsClient.js

@@ -0,0 +1,10 @@
+'use strict'
+
+const httpClient = require('./httpClient')
+
+module.exports = {
+  module: 'https',
+  OPERATION_NAME: httpClient.OPERATION_NAME,
+  patch: (https, tracer) => httpClient.patch(https, tracer),
+  unpatch: (https) => httpClient.unpatch(https)
+}

src/instrumentation/index.js

@@ -3,13 +3,15 @@
 const express = require('./express')
 const expressError = require('./expressError')
 const httpClient = require('./httpClient')
+const httpsClient = require('./httpsClient')
 const mongodbCore = require('./mongodbCore')
 const pg = require('./pg')
 
 module.exports = [
   express,
   expressError,
   httpClient,
+  httpsClient,
   mongodbCore,
   pg
 ]

src/tracer.spec.js

@@ -4,6 +4,7 @@ const { expect } = require('chai')
 const jaeger = require('jaeger-client')
 const Tracer = require('./tracer')
 const instrumentationExpress = require('./instrumentation/express')
+const instrumentationHTTPClient = require('./instrumentation/httpClient')
 
 describe('Tracer', () => {
   let tracer
@@ -27,15 +28,22 @@ describe('Tracer', () => {
 
     it('should hook require and apply instrumentation', function () {
       this.sandbox.spy(instrumentationExpress, 'patch')
+      this.sandbox.spy(instrumentationHTTPClient, 'patch')
 
       tracer = new Tracer({
         serviceName: 'my-service'
       })
 
       // eslint-disable-next-line
       const express = require('express')
+      // eslint-disable-next-line
+      const http = require('http')
+      // eslint-disable-next-line
+      const https = require('https')
 
       expect(instrumentationExpress.patch).to.be.calledWith(express, tracer._tracer)
+      expect(instrumentationHTTPClient.patch).to.be.calledWith(http, tracer._tracer)
+      expect(instrumentationHTTPClient.patch).to.be.calledWith(https, tracer._tracer)
     })
 
     it('should not apply instrumentation for not supported version', function () {