Skip to content

Commit 5c5866c

Browse files
committed
vfio/pci: Clear error and request eventfd ctx after releasing
The next use of the device will generate an underflow from the stale reference. Cc: Qian Cai <[email protected]> Fixes: 1518ac2 ("vfio/pci: fix memory leaks of eventfd ctx") Reported-by: Daniel Wagner <[email protected]> Reviewed-by: Cornelia Huck <[email protected]> Tested-by: Daniel Wagner <[email protected]> Signed-off-by: Alex Williamson <[email protected]>
1 parent b3a9e3b commit 5c5866c

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

drivers/vfio/pci/vfio_pci.c

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -521,10 +521,14 @@ static void vfio_pci_release(void *device_data)
521521
vfio_pci_vf_token_user_add(vdev, -1);
522522
vfio_spapr_pci_eeh_release(vdev->pdev);
523523
vfio_pci_disable(vdev);
524-
if (vdev->err_trigger)
524+
if (vdev->err_trigger) {
525525
eventfd_ctx_put(vdev->err_trigger);
526-
if (vdev->req_trigger)
526+
vdev->err_trigger = NULL;
527+
}
528+
if (vdev->req_trigger) {
527529
eventfd_ctx_put(vdev->req_trigger);
530+
vdev->req_trigger = NULL;
531+
}
528532
}
529533

530534
mutex_unlock(&vdev->reflck->lock);

0 commit comments

Comments
 (0)