Ignore extra SDL_Keymod bits instead of defaulting to "no mods"

Author: kolen

changelog.md

@@ -1,6 +1,11 @@
 In this file will be listed the changes, especially the breaking ones that one should be careful of
 when upgrading from a version of rust-sdl2 to another.
 
+### v0.32.3 (unreleased)
+
+[PR #882](https://github.com/Rust-SDL2/rust-sdl2/pull/882)
+Ignore unknown bits in `SDL_Keysym`'s `mod` field (key modifiers) when constructing `Event::KeyDown` and `Event::KeyUp`. Deprecate `sdl2::event::Event::unwrap_keymod`, which had been made public accidentally.
+
 ### v0.32.1
 
 [PR #868](https://github.com/Rust-SDL2/rust-sdl2/pull/868):

src/sdl2/event.rs

@@ -1278,7 +1278,7 @@ impl Event {
                     window_id: event.windowID,
                     keycode: Keycode::from_i32(event.keysym.sym as i32),
                     scancode: Scancode::from_i32(event.keysym.scancode as i32),
-                    keymod: Event::unwrap_keymod(keyboard::Mod::from_bits(event.keysym.mod_)),
+                    keymod: keyboard::Mod::from_bits_truncate(event.keysym.mod_),
                     repeat: event.repeat != 0
                 }
             }
@@ -1290,7 +1290,7 @@ impl Event {
                     window_id: event.windowID,
                     keycode: Keycode::from_i32(event.keysym.sym as i32),
                     scancode: Scancode::from_i32(event.keysym.scancode as i32),
-                    keymod: keyboard::Mod::from_bits(event.keysym.mod_).unwrap(),
+                    keymod: keyboard::Mod::from_bits_truncate(event.keysym.mod_),
                     repeat: event.repeat != 0
                 }
             }
@@ -1619,6 +1619,7 @@ impl Event {
         }}                      // close unsafe & match
     }
 
+    #[deprecated(since = "0.32.3", note = "This method has been made public accidentally")]
     pub fn unwrap_keymod(keymod_option: Option<keyboard::Mod>) -> keyboard::Mod {
         match keymod_option {
             None => keyboard::Mod::empty(),