Skip to content

Use git submodule for bundled SDL2 #1148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
OlegOAndreev opened this issue Sep 11, 2021 · 1 comment · Fixed by #1150
Closed

Use git submodule for bundled SDL2 #1148

OlegOAndreev opened this issue Sep 11, 2021 · 1 comment · Fixed by #1150
Labels
build-process Everything related to build.rs, or the build process in general

Comments

@OlegOAndreev
Copy link
Contributor

Currently sdl2-sys downloads SDL2-version.tar.gz from https://libsdl.org for every target when using "bundled" feature. This has two downsides:

  1. Multiple copies of SDL2 are located in target folders.
  2. Build process depends on external website.

Many other -sys crates use git submodules and include the C/C++ source code in the published crate. Now that SDL official repository was moved to Github, would you consider switching to using git submodule?

Currently SDL2 source size is around 80Mb. If you feel that the size bump is too big for users who do not use bundled feature, a separate crate could be used for bundled sources.

@Cobrand
Copy link
Member

Cobrand commented Sep 13, 2021

Yes, we could do that.

@Cobrand Cobrand added the build-process Everything related to build.rs, or the build process in general label Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-process Everything related to build.rs, or the build process in general
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants