Skip to content

Better Debug for Event #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vorner opened this issue Jan 2, 2018 · 1 comment
Closed

Better Debug for Event #742

vorner opened this issue Jan 2, 2018 · 1 comment

Comments

@vorner
Copy link

vorner commented Jan 2, 2018

Hello

The Event enum implements its own Debug and shows only the discriminant (eg. Event::KeyUp), without the content. Is there an actual reason not to just derive it and get all the content? The content seems useful in logs.
@Cobrand
Copy link
Member

Cobrand commented Jan 3, 2018

Related to #740 which was just merged; the main reason is that that part of the code was from 3 years ago, and I think "#[derive]" was not really a thing before 1.0 rust.

Anyway, the PR was just merged to if you use master you should be able to have the proper Debug implementation for Event.

@Cobrand Cobrand closed this as completed Jan 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Cobrand @vorner