Skip to content

Commit 032a2c4

Browse files
Matthias Kaehlckemasahir0y
Matthias Kaehlcke
authored andcommitted
x86/build: Use __cc-option for boot code compiler options
cc-option is used to enable compiler options for the boot code if they are available. The macro uses KBUILD_CFLAGS and KBUILD_CPPFLAGS for the check, however these flags aren't used to build the boot code, in consequence cc-option can yield wrong results. For example -mpreferred-stack-boundary=2 is never set with a 64-bit compiler, since the setting is only valid for 16 and 32-bit binaries. This is also the case for 32-bit kernel builds, because the option -m32 is added to KBUILD_CFLAGS after the assignment of REALMODE_CFLAGS. Use __cc-option instead of cc-option for the boot mode options. The macro receives the compiler options as parameter instead of using KBUILD_C*FLAGS, for the boot code we pass REALMODE_CFLAGS. Also use separate statements for the __cc-option checks instead of performing them in the initial assignment of REALMODE_CFLAGS since the variable is an input of the macro. Signed-off-by: Matthias Kaehlcke <[email protected]> Acked-by: Ingo Molnar <[email protected]> Signed-off-by: Masahiro Yamada <[email protected]>
1 parent 9f3f1fd commit 032a2c4

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

Diff for: arch/x86/Makefile

+5-4
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,11 @@ REALMODE_CFLAGS := $(M16_CFLAGS) -g -Os -D__KERNEL__ \
2424
-DDISABLE_BRANCH_PROFILING \
2525
-Wall -Wstrict-prototypes -march=i386 -mregparm=3 \
2626
-fno-strict-aliasing -fomit-frame-pointer -fno-pic \
27-
-mno-mmx -mno-sse \
28-
$(call cc-option, -ffreestanding) \
29-
$(call cc-option, -fno-stack-protector) \
30-
$(call cc-option, -mpreferred-stack-boundary=2)
27+
-mno-mmx -mno-sse
28+
29+
REALMODE_CFLAGS += $(call __cc-option, $(CC), $(REALMODE_CFLAGS), -ffreestanding)
30+
REALMODE_CFLAGS += $(call __cc-option, $(CC), $(REALMODE_CFLAGS), -fno-stack-protector)
31+
REALMODE_CFLAGS += $(call __cc-option, $(CC), $(REALMODE_CFLAGS), -mpreferred-stack-boundary=2)
3132
export REALMODE_CFLAGS
3233

3334
# BITS is used as extension for files which are available in a 32 bit

0 commit comments

Comments
 (0)