Skip to content

Commit 8618c4b

Browse files
wedsonaffbq
authored andcommitted
rust: cred: add Rust abstraction for struct cred
Add a wrapper around `struct cred` called `Credential`, and provide functionality to get the `Credential` associated with a `File`. Rust Binder must check the credentials of processes when they attempt to perform various operations, and these checks usually take a `&Credential` as parameter. The security_binder_set_context_mgr function would be one example. This patch is necessary to access these security_* methods from Rust. Signed-off-by: Wedson Almeida Filho <[email protected]> Co-developed-by: Alice Ryhl <[email protected]> Reviewed-by: Trevor Gross <[email protected]> Reviewed-by: Benno Lossin <[email protected]> Reviewed-by: Martin Rodriguez Reboredo <[email protected]> Signed-off-by: Alice Ryhl <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent b229d7c commit 8618c4b

File tree

5 files changed

+104
-0
lines changed

5 files changed

+104
-0
lines changed

rust/bindings/bindings_helper.h

+1
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
#include <linux/blk_types.h>
1111
#include <linux/blk-mq.h>
1212
#include <linux/blkdev.h>
13+
#include <linux/cred.h>
1314
#include <linux/errname.h>
1415
#include <linux/ethtool.h>
1516
#include <linux/file.h>

rust/helpers.c

+13
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
#include <kunit/test-bug.h>
2424
#include <linux/bug.h>
2525
#include <linux/build_bug.h>
26+
#include <linux/cred.h>
2627
#include <linux/device.h>
2728
#include <linux/err.h>
2829
#include <linux/errname.h>
@@ -214,6 +215,18 @@ struct file *rust_helper_get_file(struct file *f)
214215
}
215216
EXPORT_SYMBOL_GPL(rust_helper_get_file);
216217

218+
const struct cred *rust_helper_get_cred(const struct cred *cred)
219+
{
220+
return get_cred(cred);
221+
}
222+
EXPORT_SYMBOL_GPL(rust_helper_get_cred);
223+
224+
void rust_helper_put_cred(const struct cred *cred)
225+
{
226+
put_cred(cred);
227+
}
228+
EXPORT_SYMBOL_GPL(rust_helper_put_cred);
229+
217230
/*
218231
* `bindgen` binds the C `size_t` type as the Rust `usize` type, so we can
219232
* use it in contexts where Rust expects a `usize` like slice (array) indices.

rust/kernel/cred.rs

+76
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,76 @@
1+
// SPDX-License-Identifier: GPL-2.0
2+
3+
// Copyright (C) 2024 Google LLC.
4+
5+
//! Credentials management.
6+
//!
7+
//! C header: [`include/linux/cred.h`](srctree/include/linux/cred.h).
8+
//!
9+
//! Reference: <https://www.kernel.org/doc/html/latest/security/credentials.html>
10+
11+
use crate::{
12+
bindings,
13+
types::{AlwaysRefCounted, Opaque},
14+
};
15+
16+
/// Wraps the kernel's `struct cred`.
17+
///
18+
/// Credentials are used for various security checks in the kernel.
19+
///
20+
/// Most fields of credentials are immutable. When things have their credentials changed, that
21+
/// happens by replacing the credential instead of changing an existing credential. See the [kernel
22+
/// documentation][ref] for more info on this.
23+
///
24+
/// # Invariants
25+
///
26+
/// Instances of this type are always ref-counted, that is, a call to `get_cred` ensures that the
27+
/// allocation remains valid at least until the matching call to `put_cred`.
28+
///
29+
/// [ref]: https://www.kernel.org/doc/html/latest/security/credentials.html
30+
#[repr(transparent)]
31+
pub struct Credential(Opaque<bindings::cred>);
32+
33+
// SAFETY:
34+
// - `Credential::dec_ref` can be called from any thread.
35+
// - It is okay to send ownership of `Credential` across thread boundaries.
36+
unsafe impl Send for Credential {}
37+
38+
// SAFETY: It's OK to access `Credential` through shared references from other threads because
39+
// we're either accessing properties that don't change or that are properly synchronised by C code.
40+
unsafe impl Sync for Credential {}
41+
42+
impl Credential {
43+
/// Creates a reference to a [`Credential`] from a valid pointer.
44+
///
45+
/// # Safety
46+
///
47+
/// The caller must ensure that `ptr` is valid and remains valid for the lifetime of the
48+
/// returned [`Credential`] reference.
49+
pub unsafe fn from_ptr<'a>(ptr: *const bindings::cred) -> &'a Credential {
50+
// SAFETY: The safety requirements guarantee the validity of the dereference, while the
51+
// `Credential` type being transparent makes the cast ok.
52+
unsafe { &*ptr.cast() }
53+
}
54+
55+
/// Returns the effective UID of the given credential.
56+
pub fn euid(&self) -> bindings::kuid_t {
57+
// SAFETY: By the type invariant, we know that `self.0` is valid. Furthermore, the `euid`
58+
// field of a credential is never changed after initialization, so there is no potential
59+
// for data races.
60+
unsafe { (*self.0.get()).euid }
61+
}
62+
}
63+
64+
// SAFETY: The type invariants guarantee that `Credential` is always ref-counted.
65+
unsafe impl AlwaysRefCounted for Credential {
66+
fn inc_ref(&self) {
67+
// SAFETY: The existence of a shared reference means that the refcount is nonzero.
68+
unsafe { bindings::get_cred(self.0.get()) };
69+
}
70+
71+
unsafe fn dec_ref(obj: core::ptr::NonNull<Credential>) {
72+
// SAFETY: The safety requirements guarantee that the refcount is nonzero. The cast is okay
73+
// because `Credential` has the same representation as `struct cred`.
74+
unsafe { bindings::put_cred(obj.cast().as_ptr()) };
75+
}
76+
}

rust/kernel/fs/file.rs

+13
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
1010
use crate::{
1111
bindings,
12+
cred::Credential,
1213
error::{code::*, Error, Result},
1314
types::{ARef, AlwaysRefCounted, Opaque},
1415
};
@@ -274,6 +275,18 @@ impl LocalFile {
274275
self.inner.get()
275276
}
276277

278+
/// Returns the credentials of the task that originally opened the file.
279+
pub fn cred(&self) -> &Credential {
280+
// SAFETY: It's okay to read the `f_cred` field without synchronization because `f_cred` is
281+
// never changed after initialization of the file.
282+
let ptr = unsafe { (*self.as_ptr()).f_cred };
283+
284+
// SAFETY: The signature of this function ensures that the caller will only access the
285+
// returned credential while the file is still valid, and the C side ensures that the
286+
// credential stays valid at least as long as the file.
287+
unsafe { Credential::from_ptr(ptr) }
288+
}
289+
277290
/// Returns the flags associated with the file.
278291
///
279292
/// The flags are a combination of the constants in [`flags`].

rust/kernel/lib.rs

+1
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ pub mod alloc;
3030
#[cfg(CONFIG_BLOCK)]
3131
pub mod block;
3232
mod build_assert;
33+
pub mod cred;
3334
pub mod device;
3435
pub mod error;
3536
#[cfg(CONFIG_RUST_FW_LOADER_ABSTRACTIONS)]

0 commit comments

Comments
 (0)