Skip to content

Commit 2a4049c

Browse files
Lukas742Lukas742
authored
feat: update @ui5/webcomponents to ~2.4.0 (#6585)
1 parent a74ffbc commit 2a4049c

File tree

35 files changed

+1477
-225
lines changed

35 files changed

+1477
-225
lines changed

‎.storybook/custom-element-manifests/fiori.json

Lines changed: 261 additions & 19 deletions
Large diffs are not rendered by default.

‎.storybook/custom-element-manifests/main.json

Lines changed: 597 additions & 69 deletions
Large diffs are not rendered by default.

‎.storybook/tsconfig.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,5 @@
33
"compilerOptions": {
44
"allowJs": true
55
},
6-
"include": ["./**/*.js", "./**/*.tsx"]
6+
"include": ["./**/*.js", "./**/*.tsx", "./**/*.ts"]
77
}

‎.storybook/utils.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,8 @@ const replaceSubComps = {
6060
ToolbarItem: ['ToolbarSeparator', 'ToolbarSpacer', 'ToolbarButton', 'ToolbarSelect', 'ToolbarSelectOption'],
6161
TreeItemBase: ['TreeItem', 'TreeItemCustom'],
6262
AvatarGroupItem: ['Avatar'],
63-
TableFeature: ['TableGrowing', 'TableSelection']
63+
TableFeature: ['TableGrowing', 'TableSelection'],
64+
SideNavigationItemBase: ['SideNavigationItem', 'SideNavigationGroup', 'SideNavigationSubItem']
6465
};
6566

6667
function findSubComponentsRecursively(moduleName: string, cem: any): string[] {

‎package.json

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,9 @@
2323
"lerna:version-dryrun": "lerna version --conventional-graduate --no-git-tag-version --no-push",
2424
"wrappers:main": "WITH_WEB_COMPONENT_IMPORT_PATH='../../internal/withWebComponent.js' INTERFACES_IMPORT_PATH='../../types/index.js' node packages/cli/dist/bin/index.js create-wrappers --packageName @ui5/webcomponents --out ./packages/main/src/webComponents --additionalComponentNote 'This is a UI5 Web Component! [Repository](https://github.com/SAP/ui5-webcomponents) | [Documentation](https://sap.github.io/ui5-webcomponents/)'",
2525
"wrappers:fiori": "WITH_WEB_COMPONENT_IMPORT_PATH='../../internal/withWebComponent.js' INTERFACES_IMPORT_PATH='../../types/index.js' node packages/cli/dist/bin/index.js create-wrappers --packageName @ui5/webcomponents-fiori --out ./packages/main/src/webComponents --additionalComponentNote 'This is a UI5 Web Component! [Repository](https://github.com/SAP/ui5-webcomponents) | [Documentation](https://sap.github.io/ui5-webcomponents/)'",
26-
"wrappers:compat": "WITH_WEB_COMPONENT_IMPORT_PATH='@ui5/webcomponents-react/dist/internal/withWebComponent.js' node packages/cli/dist/bin/index.js create-wrappers --packageName @ui5/webcomponents-compat --out ./packages/compat/src/components --additionalComponentNote 'This is a UI5 Web Component! [Repository](https://github.com/SAP/ui5-webcomponents) | [Documentation](https://sap.github.io/ui5-webcomponents/)' && prettier --log-level silent --write ./packages/compat/src/components && eslint --ext .ts,.tsx --fix ./packages/compat/src/components/*/index.tsx",
27-
"create-webcomponents-wrapper": "(cd packages/cli && tsc) && yarn run wrappers:main && yarn run wrappers:fiori && yarn run wrappers:compat && prettier --log-level silent --write ./packages/main/src/webComponents && eslint --ext .ts,.tsx --fix ./packages/main/src/webComponents/*/index.tsx && yarn run sb:prepare-cem",
26+
"wrappers:compat": "WITH_WEB_COMPONENT_IMPORT_PATH='@ui5/webcomponents-react/dist/internal/withWebComponent.js' node packages/cli/dist/bin/index.js create-wrappers --packageName @ui5/webcomponents-compat --out ./packages/compat/src/components --additionalComponentNote 'This is a UI5 Web Component! [Repository](https://github.com/SAP/ui5-webcomponents) | [Documentation](https://sap.github.io/ui5-webcomponents/)' && prettier --log-level silent --write ./packages/compat/src/components",
27+
"create-webcomponents-wrapper": "(cd packages/cli && tsc) && yarn run wrappers:main && yarn run wrappers:fiori && prettier --log-level silent --write ./packages/main/src/webComponents && eslint --fix ./packages/main/src/webComponents/*/index.tsx && yarn run sb:prepare-cem",
28+
"create-webcomponents-wrapper-compat": "(cd packages/cli && tsc) && yarn run wrappers:compat && yarn run sb:prepare-cem && eslint --fix ./packages/compat/src/components/*/index.tsx",
2829
"chromatic": "cross-env STORYBOOK_ENV=chromatic npx chromatic --build-script-name build:storybook",
2930
"postinstall": "husky && yarn setup",
3031
"create-cypress-commands-docs": "typedoc && rimraf temp/typedoc",
@@ -39,10 +40,10 @@
3940
"@storybook/react": "8.3.6",
4041
"@storybook/react-vite": "8.3.6",
4142
"@storybook/theming": "8.3.6",
42-
"@ui5/webcomponents": "2.3.0",
43-
"@ui5/webcomponents-compat": "2.3.0",
44-
"@ui5/webcomponents-fiori": "2.3.0",
45-
"@ui5/webcomponents-icons": "2.3.0",
43+
"@ui5/webcomponents": "2.4.0",
44+
"@ui5/webcomponents-compat": "2.4.0",
45+
"@ui5/webcomponents-fiori": "2.4.0",
46+
"@ui5/webcomponents-icons": "2.4.0",
4647
"react": "^18.3.1",
4748
"react-dom": "^18.3.1",
4849
"remark-gfm": "^4.0.0",
@@ -64,7 +65,7 @@
6465
"@types/react": "^18.3.4",
6566
"@types/react-dom": "^18.3.0",
6667
"@types/use-sync-external-store": "^0.0.6",
67-
"@ui5/webcomponents-tools": "2.3.0",
68+
"@ui5/webcomponents-tools": "2.4.0",
6869
"@vitejs/plugin-react": "^4.2.0",
6970
"chromatic": "^11.0.0",
7071
"cssnano": "^7.0.0",

‎packages/base/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
},
3232
"peerDependencies": {
3333
"@types/react": "*",
34-
"@ui5/webcomponents-base": "~2.3.0",
34+
"@ui5/webcomponents-base": "~2.4.0",
3535
"react": "^18 || ^19"
3636
},
3737
"peerDependenciesMeta": {

‎packages/charts/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@
3939
"recharts": "2.13.3"
4040
},
4141
"peerDependencies": {
42-
"@ui5/webcomponents-react": "~2.3.0",
43-
"@ui5/webcomponents-react-base": "~2.3.0",
42+
"@ui5/webcomponents-react": "~2.4.0",
43+
"@ui5/webcomponents-react-base": "~2.4.0",
4444
"react": "^18"
4545
},
4646
"publishConfig": {

‎packages/cli/src/util/recursiveManifestResolver.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,8 @@ const EXCLUDED_MEMBERS = new Set([
2424
'onEnterDOM',
2525
'onExitDOM',
2626
'onInvalidation',
27-
'getStaticAreaItemDomRef'
27+
'getStaticAreaItemDomRef',
28+
'fireDecoratorEvent'
2829
]);
2930

3031
function mergeArraysWithoutDuplicates(currentValues: any[], newValue: any) {

‎packages/compat/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,8 @@
4141
"peerDependencies": {
4242
"@types/react": "*",
4343
"@types/react-dom": "*",
44-
"@ui5/webcomponents-compat": "~2.3.0",
45-
"@ui5/webcomponents-react": "~2.3.0",
44+
"@ui5/webcomponents-compat": "~2.4.0",
45+
"@ui5/webcomponents-react": "~2.4.0",
4646
"react": "^18 || ^19",
4747
"react-dom": "^18 || ^19"
4848
},

‎packages/main/package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,10 +58,10 @@
5858
"peerDependencies": {
5959
"@types/react": "*",
6060
"@types/react-dom": "*",
61-
"@ui5/webcomponents": "~2.3.0",
62-
"@ui5/webcomponents-base": "~2.3.0",
63-
"@ui5/webcomponents-fiori": "~2.3.0",
64-
"@ui5/webcomponents-icons": "~2.3.0",
61+
"@ui5/webcomponents": "~2.4.0",
62+
"@ui5/webcomponents-base": "~2.4.0",
63+
"@ui5/webcomponents-fiori": "~2.4.0",
64+
"@ui5/webcomponents-icons": "~2.4.0",
6565
"react": "^18 || ^19",
6666
"react-dom": "^18 || ^19"
6767
},

‎packages/main/src/webComponents/BarcodeScannerDialog/index.tsx

Lines changed: 43 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import type {
66
BarcodeScannerDialogScanSuccessEventDetail
77
} from '@ui5/webcomponents-fiori/dist/BarcodeScannerDialog.js';
88
import { withWebComponent } from '../../internal/withWebComponent.js';
9-
import type { CommonProps, Ui5CustomEvent, Ui5DomRef } from '../../types/index.js';
9+
import type { CommonProps, Ui5CustomEvent, Ui5DomRef, UI5WCSlotsNode } from '../../types/index.js';
1010

1111
interface BarcodeScannerDialogAttributes {
1212
/**
@@ -22,9 +22,49 @@ interface BarcodeScannerDialogDomRef extends Required<BarcodeScannerDialogAttrib
2222

2323
interface BarcodeScannerDialogPropTypes
2424
extends BarcodeScannerDialogAttributes,
25-
Omit<CommonProps, keyof BarcodeScannerDialogAttributes | 'onClose' | 'onScanError' | 'onScanSuccess'> {
25+
Omit<
26+
CommonProps,
27+
keyof BarcodeScannerDialogAttributes | 'footer' | 'header' | 'onClose' | 'onScanError' | 'onScanSuccess'
28+
> {
29+
/**
30+
* Defines the footer HTML Element.
31+
*
32+
* **Note:** When you provide custom content for the `footer` slot, the default close button is not rendered.
33+
* This means you need to include your own mechanism within the custom `footer` to close the dialog,
34+
* such as a button with an event listener that closes the dialog.
35+
*
36+
* **Note:** If the `footer` slot is not provided, a default footer with a close button is rendered automatically,
37+
* allowing users to close the dialog without any additional implementation.
38+
*
39+
* __Note:__ The content of the prop will be rendered into a [&lt;slot&gt;](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/slot) by assigning the respective [slot](https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/slot) attribute (`slot="footer"`).
40+
* Since you can't change the DOM order of slots when declaring them within a prop, it might prove beneficial to manually mount them as part of the component's children, especially when facing problems with the reading order of screen readers.
41+
*
42+
* __Note:__ When passing a custom React component to this prop, you have to make sure your component reads the `slot` prop and appends it to the most outer element of your component.
43+
* Learn more about it [here](https://sap.github.io/ui5-webcomponents-react/v2/?path=/docs/knowledge-base-handling-slots--docs).
44+
*
45+
* **Note:** Available since [v2.4.0](https://github.com/SAP/ui5-webcomponents/releases/tag/v2.4.0) of **@ui5/webcomponents-fiori**.
46+
*/
47+
footer?: UI5WCSlotsNode;
48+
49+
/**
50+
* Defines the header HTML Element.
51+
*
52+
* **Note:** If `header` slot is provided, the labelling of the dialog is a responsibility of the application developer.
53+
* `accessibleName` should be used.
54+
*
55+
* __Note:__ The content of the prop will be rendered into a [&lt;slot&gt;](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/slot) by assigning the respective [slot](https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/slot) attribute (`slot="header"`).
56+
* Since you can't change the DOM order of slots when declaring them within a prop, it might prove beneficial to manually mount them as part of the component's children, especially when facing problems with the reading order of screen readers.
57+
*
58+
* __Note:__ When passing a custom React component to this prop, you have to make sure your component reads the `slot` prop and appends it to the most outer element of your component.
59+
* Learn more about it [here](https://sap.github.io/ui5-webcomponents-react/v2/?path=/docs/knowledge-base-handling-slots--docs).
60+
*
61+
* **Note:** Available since [v2.4.0](https://github.com/SAP/ui5-webcomponents/releases/tag/v2.4.0) of **@ui5/webcomponents-fiori**.
62+
*/
63+
header?: UI5WCSlotsNode;
2664
/**
2765
* Fired when the user closes the component.
66+
*
67+
* **Note:** Available since [v2.0.0](https://github.com/SAP/ui5-webcomponents/releases/tag/v2.0.0) of **@ui5/webcomponents-fiori**.
2868
*/
2969
onClose?: (event: Ui5CustomEvent<BarcodeScannerDialogDomRef>) => void;
3070

@@ -58,7 +98,7 @@ const BarcodeScannerDialog = withWebComponent<BarcodeScannerDialogPropTypes, Bar
5898
'ui5-barcode-scanner-dialog',
5999
[],
60100
['open'],
61-
[],
101+
['footer', 'header'],
62102
['close', 'scan-error', 'scan-success']
63103
);
64104

‎packages/main/src/webComponents/DatePicker/index.tsx

Lines changed: 22 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,13 @@ interface DatePickerPropTypes
166166
extends DatePickerAttributes,
167167
Omit<
168168
CommonProps,
169-
keyof DatePickerAttributes | 'valueStateMessage' | 'onChange' | 'onInput' | 'onValueStateChange'
169+
| keyof DatePickerAttributes
170+
| 'valueStateMessage'
171+
| 'onChange'
172+
| 'onClose'
173+
| 'onInput'
174+
| 'onOpen'
175+
| 'onValueStateChange'
170176
> {
171177
/**
172178
* Defines the value state message that will be displayed as pop up under the component.
@@ -190,13 +196,27 @@ interface DatePickerPropTypes
190196
*/
191197
onChange?: (event: Ui5CustomEvent<DatePickerDomRef, DatePickerChangeEventDetail>) => void;
192198

199+
/**
200+
* Fired after the value-help dialog of the component is closed.
201+
*
202+
* **Note:** Available since [v2.4.0](https://github.com/SAP/ui5-webcomponents/releases/tag/v2.4.0) of **@ui5/webcomponents**.
203+
*/
204+
onClose?: (event: Ui5CustomEvent<DatePickerDomRef>) => void;
205+
193206
/**
194207
* Fired when the value of the component is changed at each key stroke.
195208
*
196209
* **Note:** Call `event.preventDefault()` inside the handler of this event to prevent its default action/s.
197210
*/
198211
onInput?: (event: Ui5CustomEvent<DatePickerDomRef, DatePickerInputEventDetail>) => void;
199212

213+
/**
214+
* Fired after the value-help dialog of the component is opened.
215+
*
216+
* **Note:** Available since [v2.4.0](https://github.com/SAP/ui5-webcomponents/releases/tag/v2.4.0) of **@ui5/webcomponents**.
217+
*/
218+
onOpen?: (event: Ui5CustomEvent<DatePickerDomRef>) => void;
219+
200220
/**
201221
* Fired before the value state of the component is updated internally.
202222
* The event is preventable, meaning that if it's default action is
@@ -298,7 +318,7 @@ const DatePicker = withWebComponent<DatePickerPropTypes, DatePickerDomRef>(
298318
],
299319
['disabled', 'hideWeekNumbers', 'open', 'readonly', 'required'],
300320
['valueStateMessage'],
301-
['change', 'input', 'value-state-change']
321+
['change', 'close', 'input', 'open', 'value-state-change']
302322
);
303323

304324
DatePicker.displayName = 'DatePicker';

‎packages/main/src/webComponents/DateRangePicker/index.tsx

Lines changed: 22 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,13 @@ interface DateRangePickerPropTypes
188188
extends DateRangePickerAttributes,
189189
Omit<
190190
CommonProps,
191-
keyof DateRangePickerAttributes | 'valueStateMessage' | 'onChange' | 'onInput' | 'onValueStateChange'
191+
| keyof DateRangePickerAttributes
192+
| 'valueStateMessage'
193+
| 'onChange'
194+
| 'onClose'
195+
| 'onInput'
196+
| 'onOpen'
197+
| 'onValueStateChange'
192198
> {
193199
/**
194200
* Defines the value state message that will be displayed as pop up under the component.
@@ -212,13 +218,27 @@ interface DateRangePickerPropTypes
212218
*/
213219
onChange?: (event: Ui5CustomEvent<DateRangePickerDomRef, DatePickerChangeEventDetail>) => void;
214220

221+
/**
222+
* Fired after the value-help dialog of the component is closed.
223+
*
224+
* **Note:** Available since [v2.4.0](https://github.com/SAP/ui5-webcomponents/releases/tag/v2.4.0) of **@ui5/webcomponents**.
225+
*/
226+
onClose?: (event: Ui5CustomEvent<DateRangePickerDomRef>) => void;
227+
215228
/**
216229
* Fired when the value of the component is changed at each key stroke.
217230
*
218231
* **Note:** Call `event.preventDefault()` inside the handler of this event to prevent its default action/s.
219232
*/
220233
onInput?: (event: Ui5CustomEvent<DateRangePickerDomRef, DatePickerInputEventDetail>) => void;
221234

235+
/**
236+
* Fired after the value-help dialog of the component is opened.
237+
*
238+
* **Note:** Available since [v2.4.0](https://github.com/SAP/ui5-webcomponents/releases/tag/v2.4.0) of **@ui5/webcomponents**.
239+
*/
240+
onOpen?: (event: Ui5CustomEvent<DateRangePickerDomRef>) => void;
241+
222242
/**
223243
* Fired before the value state of the component is updated internally.
224244
* The event is preventable, meaning that if it's default action is
@@ -273,7 +293,7 @@ const DateRangePicker = withWebComponent<DateRangePickerPropTypes, DateRangePick
273293
],
274294
['disabled', 'hideWeekNumbers', 'open', 'readonly', 'required'],
275295
['valueStateMessage'],
276-
['change', 'input', 'value-state-change']
296+
['change', 'close', 'input', 'open', 'value-state-change']
277297
);
278298

279299
DateRangePicker.displayName = 'DateRangePicker';

‎packages/main/src/webComponents/DateTimePicker/index.tsx

Lines changed: 22 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,13 @@ interface DateTimePickerPropTypes
166166
extends DateTimePickerAttributes,
167167
Omit<
168168
CommonProps,
169-
keyof DateTimePickerAttributes | 'valueStateMessage' | 'onChange' | 'onInput' | 'onValueStateChange'
169+
| keyof DateTimePickerAttributes
170+
| 'valueStateMessage'
171+
| 'onChange'
172+
| 'onClose'
173+
| 'onInput'
174+
| 'onOpen'
175+
| 'onValueStateChange'
170176
> {
171177
/**
172178
* Defines the value state message that will be displayed as pop up under the component.
@@ -190,13 +196,27 @@ interface DateTimePickerPropTypes
190196
*/
191197
onChange?: (event: Ui5CustomEvent<DateTimePickerDomRef, DatePickerChangeEventDetail>) => void;
192198

199+
/**
200+
* Fired after the value-help dialog of the component is closed.
201+
*
202+
* **Note:** Available since [v2.4.0](https://github.com/SAP/ui5-webcomponents/releases/tag/v2.4.0) of **@ui5/webcomponents**.
203+
*/
204+
onClose?: (event: Ui5CustomEvent<DateTimePickerDomRef>) => void;
205+
193206
/**
194207
* Fired when the value of the component is changed at each key stroke.
195208
*
196209
* **Note:** Call `event.preventDefault()` inside the handler of this event to prevent its default action/s.
197210
*/
198211
onInput?: (event: Ui5CustomEvent<DateTimePickerDomRef, DatePickerInputEventDetail>) => void;
199212

213+
/**
214+
* Fired after the value-help dialog of the component is opened.
215+
*
216+
* **Note:** Available since [v2.4.0](https://github.com/SAP/ui5-webcomponents/releases/tag/v2.4.0) of **@ui5/webcomponents**.
217+
*/
218+
onOpen?: (event: Ui5CustomEvent<DateTimePickerDomRef>) => void;
219+
200220
/**
201221
* Fired before the value state of the component is updated internally.
202222
* The event is preventable, meaning that if it's default action is
@@ -280,7 +300,7 @@ const DateTimePicker = withWebComponent<DateTimePickerPropTypes, DateTimePickerD
280300
],
281301
['disabled', 'hideWeekNumbers', 'open', 'readonly', 'required'],
282302
['valueStateMessage'],
283-
['change', 'input', 'value-state-change']
303+
['change', 'close', 'input', 'open', 'value-state-change']
284304
);
285305

286306
DateTimePicker.displayName = 'DateTimePicker';

‎packages/main/src/webComponents/Dialog/index.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -171,26 +171,26 @@ interface DialogPropTypes
171171
*/
172172
header?: UI5WCSlotsNode;
173173
/**
174-
* Fired before the component is closed. This event can be cancelled, which will prevent the popup from closing. **This event does not bubble.**
174+
* Fired before the component is closed. This event can be cancelled, which will prevent the popup from closing.
175175
*
176176
* **Note:** Call `event.preventDefault()` inside the handler of this event to prevent its default action/s.
177177
*/
178178
onBeforeClose?: (event: Ui5CustomEvent<DialogDomRef, PopupBeforeCloseEventDetail>) => void;
179179

180180
/**
181-
* Fired before the component is opened. This event can be cancelled, which will prevent the popup from opening. **This event does not bubble.**
181+
* Fired before the component is opened. This event can be cancelled, which will prevent the popup from opening.
182182
*
183183
* **Note:** Call `event.preventDefault()` inside the handler of this event to prevent its default action/s.
184184
*/
185185
onBeforeOpen?: (event: Ui5CustomEvent<DialogDomRef>) => void;
186186

187187
/**
188-
* Fired after the component is closed. **This event does not bubble.**
188+
* Fired after the component is closed.
189189
*/
190190
onClose?: (event: Ui5CustomEvent<DialogDomRef>) => void;
191191

192192
/**
193-
* Fired after the component is opened. **This event does not bubble.**
193+
* Fired after the component is opened.
194194
*/
195195
onOpen?: (event: Ui5CustomEvent<DialogDomRef>) => void;
196196
}

‎packages/main/src/webComponents/Form/index.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,8 @@ interface FormAttributes {
4545
* - `S` - 1 column by default (1 column is recommended)
4646
* - `M` - 1 column by default (up to 2 columns are recommended)
4747
* - `L` - 2 columns by default (up to 3 columns are recommended)
48-
* - `XL` - 2 columns by default (up to 6 columns are recommended)
49-
* @default "S1 M1 L2 XL2"
48+
* - `XL` - 3 columns by default (up to 6 columns are recommended)
49+
* @default "S1 M1 L2 XL3"
5050
*/
5151
layout?: string;
5252
}
@@ -104,7 +104,7 @@ interface FormPropTypes extends FormAttributes, Omit<CommonProps, keyof FormAttr
104104
* - **S** (< 600px) – 1 column is recommended (default: 1)
105105
* - **M** (600px - 1022px) – up to 2 columns are recommended (default: 1)
106106
* - **L** (1023px - 1439px) - up to 3 columns are recommended (default: 2)
107-
* - **XL** (> 1439px) – up to 6 columns are recommended (default: 2)
107+
* - **XL** (> 1439px) – up to 6 columns are recommended (default: 3)
108108
*
109109
* To change the layout, use the `layout` property - f.e. layout="S1 M2 L3 XL6".
110110
*

‎packages/main/src/webComponents/List/index.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -197,8 +197,6 @@ interface ListPropTypes
197197
* Fired when a movable list item is dropped onto a drop target.
198198
*
199199
* **Note:** `move` event is fired only if there was a preceding `move-over` with prevented default action.
200-
*
201-
* **Note:** Call `event.preventDefault()` inside the handler of this event to prevent its default action/s.
202200
*/
203201
onMove?: (event: Ui5CustomEvent<ListDomRef, ListMoveEventDetail>) => void;
204202

0 commit comments

Comments
 (0)