Skip to content

Commit 36aa447

Browse files
authored
fix(AnalyticalTable): only show BusyIndicator if table has data (#6614)
1 parent de3c96d commit 36aa447

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

packages/main/src/components/AnalyticalTable/AnalyticalTable.cy.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1496,8 +1496,9 @@ describe('AnalyticalTable', () => {
14961496
});
14971497

14981498
it('Loading & No Data', () => {
1499-
cy.mount(<AnalyticalTable data={[]} columns={columns} loading />);
1499+
cy.mount(<AnalyticalTable data={[]} columns={columns} loading loadingDelay={0} />);
15001500
cy.get('[data-component-name="AnalyticalTableLoadingPlaceholder"]').should('be.visible');
1501+
cy.get('.ui5-busy-indicator-busy-area').should('not.exist');
15011502
cy.mount(<AnalyticalTable data={data} columns={columns} loading />);
15021503
cy.get('.ui5-busy-indicator-busy-area', { timeout: 2000 }).should('be.visible');
15031504
cy.mount(<AnalyticalTable data={data} columns={columns} loading loadingDelay={50000} />);

packages/main/src/components/AnalyticalTable/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -699,7 +699,7 @@ const AnalyticalTable = forwardRef<AnalyticalTableDomRef, AnalyticalTablePropTyp
699699
className={classNames.tableContainerWithScrollBar}
700700
data-component-name="AnalyticalTableContainerWithScrollbar"
701701
>
702-
{loading && (
702+
{loading && !!rows.length && (
703703
<BusyIndicator
704704
className={classNames.busyIndicator}
705705
active={true}

0 commit comments

Comments
 (0)