Skip to content

Commit 41f0dc9

Browse files
authored
fix(ObjectPage): use full width for header content if no image is set (#7046)
Fixes #7025
1 parent 6b43b58 commit 41f0dc9

File tree

2 files changed

+11
-4
lines changed

2 files changed

+11
-4
lines changed

packages/main/src/components/ObjectPage/ObjectPage.module.css

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,8 @@
6666
margin-block-end: 0.25rem;
6767
background-color: var(--sapObjectHeader_Background);
6868
display: grid;
69+
}
70+
.hasAvatar {
6971
grid-auto-columns: min-content calc(100% - 5rem - 2rem);
7072

7173
[data-component-name='ObjectPageHeaderContent'] {
@@ -188,4 +190,4 @@
188190
.clickArea {
189191
position: absolute;
190192
inset: 0;
191-
}
193+
}

packages/main/src/components/ObjectPage/index.tsx

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -314,17 +314,19 @@ const ObjectPage = forwardRef<ObjectPageDomRef, ObjectPagePropTypes>((props, ref
314314
<span
315315
className={classNames.headerImage}
316316
style={{ borderRadius: imageShapeCircle ? '50%' : 0, overflow: 'hidden' }}
317+
data-component-name="ObjectPageHeaderImage"
317318
>
318319
<img src={image} className={classNames.image} alt="Company Logo" />
319320
</span>
320321
);
321322
} else {
322323
return cloneElement(image, {
323324
size: AvatarSize.L,
324-
className: clsx(classNames.headerImage, image.props?.className)
325+
className: clsx(classNames.headerImage, image.props?.className),
326+
'data-component-name': 'ObjectPageHeaderImage'
325327
} as AvatarPropTypes);
326328
}
327-
}, [image, classNames.headerImage, classNames.image, imageShapeCircle]);
329+
}, [image, imageShapeCircle]);
328330

329331
const scrollToSectionById = (id: string | undefined, isSubSection = false) => {
330332
const section = getSectionElementById(objectPageRef.current, isSubSection, id);
@@ -639,7 +641,10 @@ const ObjectPage = forwardRef<ObjectPageDomRef, ObjectPagePropTypes>((props, ref
639641
//@ts-expect-error: todo remove me when forwardref has been replaced
640642
ref: componentRefHeaderContent,
641643
children: (
642-
<div className={classNames.headerContainer} data-component-name="ObjectPageHeaderContainer">
644+
<div
645+
className={clsx(classNames.headerContainer, avatar && classNames.hasAvatar)}
646+
data-component-name="ObjectPageHeaderContainer"
647+
>
643648
{avatar}
644649
{headerArea.props.children && (
645650
<div data-component-name="ObjectPageHeaderContent">{headerArea.props.children}</div>

0 commit comments

Comments
 (0)