Skip to content

Commit 4293493

Browse files
committed
fix(FilterBar): fix reordering in StrictMode (#7060)
Fixes #7013
1 parent 7f3bbaf commit 4293493

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

packages/main/src/components/FilterBar/FilterDialog.tsx

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -331,12 +331,14 @@ export const FilterDialog = (props: FilterDialogPropTypes) => {
331331
const [updatedIndex, setUpdatedIndex] = useState(undefined);
332332
useEffect(() => {
333333
if (currentReorderedItem?.index != null) {
334-
setOrderedChildren((prev: any[]) => {
335-
const { index, direction } = currentReorderedItem;
334+
const { index, direction } = currentReorderedItem;
335+
setOrderedChildren((prevChildren: ReactElement<FilterGroupItemInternalProps>[]) => {
336+
const prev = [...prevChildren];
336337
switch (direction) {
337338
case 'up':
338339
if (index > 0) {
339340
setUpdatedIndex(index - 1);
341+
340342
const temp = prev[index];
341343
prev[index] = prev[index - 1];
342344
prev[index - 1] = temp;
@@ -365,7 +367,7 @@ export const FilterDialog = (props: FilterDialogPropTypes) => {
365367
}
366368
break;
367369
}
368-
return [...prev];
370+
return prev;
369371
});
370372
void currentReorderedItem.target.focus();
371373
}

0 commit comments

Comments
 (0)