Skip to content

Commit 4d1edb5

Browse files
committed
fix(ObjectPage): use full width for header content if no image is set (#7046)
Fixes #7025
1 parent da3c19e commit 4d1edb5

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

packages/main/src/components/ObjectPage/ObjectPage.module.css

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,8 @@
6060
margin-block-end: 0.25rem;
6161
background-color: var(--sapObjectHeader_Background);
6262
display: grid;
63+
}
64+
.hasAvatar {
6365
grid-auto-columns: min-content calc(100% - 5rem - 2rem);
6466

6567
[data-component-name='ObjectPageHeaderContent'] {

packages/main/src/components/ObjectPage/index.tsx

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -295,17 +295,19 @@ const ObjectPage = forwardRef<HTMLDivElement, ObjectPagePropTypes>((props, ref)
295295
<span
296296
className={classNames.headerImage}
297297
style={{ borderRadius: imageShapeCircle ? '50%' : 0, overflow: 'hidden' }}
298+
data-component-name="ObjectPageHeaderImage"
298299
>
299300
<img src={image} className={classNames.image} alt="Company Logo" />
300301
</span>
301302
);
302303
} else {
303304
return cloneElement(image, {
304305
size: AvatarSize.L,
305-
className: clsx(classNames.headerImage, image.props?.className)
306+
className: clsx(classNames.headerImage, image.props?.className),
307+
'data-component-name': 'ObjectPageHeaderImage'
306308
} as AvatarPropTypes);
307309
}
308-
}, [image, classNames.headerImage, classNames.image, imageShapeCircle]);
310+
}, [image, imageShapeCircle]);
309311

310312
const scrollToSectionById = (id?: string, isSubSection = false) => {
311313
const section = objectPageRef.current?.querySelector<HTMLElement>(
@@ -643,7 +645,10 @@ const ObjectPage = forwardRef<HTMLDivElement, ObjectPagePropTypes>((props, ref)
643645
headerPinned: headerPinned || scrolledHeaderExpanded,
644646
ref: componentRefHeaderContent,
645647
children: (
646-
<div className={classNames.headerContainer} data-component-name="ObjectPageHeaderContainer">
648+
<div
649+
className={clsx(classNames.headerContainer, avatar && classNames.hasAvatar)}
650+
data-component-name="ObjectPageHeaderContainer"
651+
>
647652
{avatar}
648653
{(headerContent.props.children || titleInHeader) && (
649654
<div data-component-name="ObjectPageHeaderContent">

0 commit comments

Comments
 (0)