Skip to content

Commit 6059719

Browse files
authored
docs: update links & improve custom slot knowledge base entry (#6752)
SAP/ui5-webcomponents#10386 (comment)
1 parent 857d6b5 commit 6059719

File tree

4 files changed

+12
-9
lines changed

4 files changed

+12
-9
lines changed

docs/Welcome.mdx

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -103,10 +103,7 @@ UI5 Web Components and UI5 Web Components for React are both coming with the `sa
103103
children={
104104
<>
105105
UI5 Web Components for React uses the theme configuration of UI5 Web Components. Please also have a look at their{' '}
106-
<Link href="https://sap.github.io/ui5-webcomponents/playground/?path=/docs/docs-advanced-configuration--docs#theme">
107-
documentation
108-
</Link>
109-
.
106+
<Link href="https://sap.github.io/ui5-webcomponents/docs/advanced/configuration/#theme">documentation</Link>.
110107
</>
111108
}
112109
/>
@@ -182,7 +179,7 @@ export default function App() {
182179

183180
### Feature Registration
184181

185-
`@ui5/webcomponents` offers a variety of [feature (side-effect) imports](https://sap.github.io/ui5-webcomponents/playground/?path=/docs/docs-getting-started-using-features) that are available with `@ui5/webcomponents-react` as well.
182+
`@ui5/webcomponents` offers a variety of [feature (side-effect) imports](https://sap.github.io/ui5-webcomponents/docs/advanced/using-features/) that are available with `@ui5/webcomponents-react` as well.
186183
To use them you have to make sure they are imported before any other imports!
187184

188185
### Support

docs/knowledge-base/CustomComponentsSlots.mdx

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,16 @@
11
import { Meta } from '@storybook/addon-docs';
22
import { BarComponent, FaultyBarComponent } from '../knowledgeBaseExamples/slotExamples';
33
import { Footer } from '@sb/components';
4+
import { MessageStrip } from '@ui5/webcomponents-react';
45

56
<Meta title="Handling Slots" />
67

7-
# Adding custom components to slots
8+
# Adding custom React components to slots
9+
10+
<MessageStrip
11+
hideCloseButton
12+
children="Using a custom React component still requires the expected web component(s) to be rendered."
13+
/>
814

915
With our wrapper we provide an easy way to consume the `slots` of the UI5 Web Components by attaching them to a `prop`.
1016
In most cases you don't have to take anything into account, and the props can be used in a typical React way. However, there is an exception with custom components:

docs/knowledge-base/Internationalization.mdx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ That's it! You can now test whether the translations work correctly by adding e.
2929

3030
## How to add custom translations
3131

32-
_Please also read the [general configuration](https://sap.github.io/ui5-webcomponents/playground/?path=/docs/docs-advanced-configuration) and [i18n documentation](https://sap.github.io/ui5-webcomponents/playground/?path=/docs/docs-advanced-using-i18n-for-apps) of UI5 Web Components._
32+
_Please also read the [general configuration](https://sap.github.io/ui5-webcomponents/docs/advanced/configuration/) and [i18n documentation](https://sap.github.io/ui5-webcomponents/docs/advanced/using-i18n-for-apps/) of UI5 Web Components._
3333

3434
<MessageStrip
3535
design={MessageStripDesign.Information}
@@ -39,7 +39,7 @@ _Please also read the [general configuration](https://sap.github.io/ui5-webcompo
3939
When using custom translations, you have to enable the <code>fetchDefaultLanguage</code> option for UI5 Web
4040
Components. If it is not set, your default language translations (english) will be missing. Learn more about it{' '}
4141
<a
42-
href="https://sap.github.io/ui5-webcomponents/playground/?path=/docs/docs-advanced-configuration--docs#fetchdefaultlanguage"
42+
href="https://sap.github.io/ui5-webcomponents/docs/advanced/configuration/#fetchDefaultLanguage"
4343
target="_blank"
4444
>
4545
here

packages/main/src/components/MessageView/MessageView.stories.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ const meta = {
4848
<MessageItem
4949
key={3}
5050
titleText={'Warning Message Type'}
51-
subtitleText={'Warnign without details'}
51+
subtitleText={'Warning without details'}
5252
type={ValueState.Critical}
5353
counter={3}
5454
/>,

0 commit comments

Comments
 (0)