fix(VariantManagement): drop hasOwnProperty from selectedVariant.readOnly check

superdyzio · superdyzio · commit 6263f5ce1fa8 · 2024-11-18T17:25:39.000+01:00
Fixes #6617
diff --git a/packages/main/src/components/VariantManagement/index.tsx b/packages/main/src/components/VariantManagement/index.tsx
@@ -317,9 +317,7 @@ const VariantManagement = forwardRef<HTMLDivElement, VariantManagementPropTypes>
     }
   }, [safeChildrenWithFavorites]);
 
-  // todo: this applies if `readOnly` is set to `false` as well since the value is read via data-attribute and is therefore a string not a boolean
-  const showSaveBtn =
-    dirtyState && selectedVariant && !Object.prototype.hasOwnProperty.call(selectedVariant, 'readOnly');
+  const showSaveBtn = dirtyState && selectedVariant && !selectedVariant.readOnly;
 
   return (
     <div className={variantManagementClasses} style={style} {...rest} ref={ref}>

Original file line number	Diff line number	Diff line change
`@@ -317,9 +317,7 @@ const VariantManagement = forwardRef<HTMLDivElement, VariantManagementPropTypes>`
`317`	`317`	`}`
`318`	`318`	`}, [safeChildrenWithFavorites]);`
`319`	`319`
`320`		- // todo: this applies if `readOnly` is set to `false` as well since the value is read via data-attribute and is therefore a string not a boolean
`321`		`- const showSaveBtn =`
`322`		`- dirtyState && selectedVariant && !Object.prototype.hasOwnProperty.call(selectedVariant, 'readOnly');`
	`320`	`+ const showSaveBtn = dirtyState && selectedVariant && !selectedVariant.readOnly;`
`323`	`321`
`324`	`322`	`return (`
`325`	`323`	`<div className={variantManagementClasses} style={style} {...rest} ref={ref}>`