Skip to content

Commit 830ab14

Browse files
authored
fix(AnalyticalTable): remove ResizeObserver condition to avoid race conditions (#444)
1 parent a763bb8 commit 830ab14

File tree

1 file changed

+3
-9
lines changed
  • packages/main/src/components/AnalyticalTable

1 file changed

+3
-9
lines changed

packages/main/src/components/AnalyticalTable/index.tsx

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,6 @@ const AnalyticalTable: FC<TableProps> = forwardRef((props: TableProps, ref: Ref<
176176

177177
const [analyticalTableRef, reactWindowRef] = useTableScrollHandles(ref);
178178
const tableRef: RefObject<HTMLDivElement> = useRef();
179-
const resizeObserverInitialized = useRef(false);
180179
const extension = useDeprecateRenderMethods(props, 'renderExtension', 'extension');
181180

182181
const getSubRows = useCallback((row) => row[subRowsKey] || [], [subRowsKey]);
@@ -258,21 +257,16 @@ const AnalyticalTable: FC<TableProps> = forwardRef((props: TableProps, ref: Ref<
258257

259258
useEffect(() => {
260259
// @ts-ignore
261-
const tableWidthObserver = new ResizeObserver(() => {
262-
if (resizeObserverInitialized.current) {
263-
updateTableClientWidth();
264-
}
265-
resizeObserverInitialized.current = true;
266-
});
260+
const tableWidthObserver = new ResizeObserver(updateTableClientWidth);
267261
tableWidthObserver.observe(tableRef.current);
268262
return () => {
269263
tableWidthObserver.disconnect();
270264
};
271-
}, [updateTableClientWidth, resizeObserverInitialized]);
265+
}, [updateTableClientWidth]);
272266

273267
useEffect(() => {
274268
updateTableClientWidth();
275-
}, []);
269+
}, [updateTableClientWidth]);
276270

277271
useEffect(() => {
278272
dispatch({ type: 'SET_GROUP_BY', payload: groupBy });

0 commit comments

Comments
 (0)