Skip to content

Commit e65d8da

Browse files
committed
fix(AnalyticalTable): use correct border-bottom for selected row
1 parent f25d2d1 commit e65d8da

File tree

1 file changed

+29
-25
lines changed

1 file changed

+29
-25
lines changed

packages/main/src/components/AnalyticalTable/AnayticalTable.jss.ts

Lines changed: 29 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -5,18 +5,18 @@ const styles = {
55
tableContainer: {
66
width: '100%',
77
height: `calc(100% - ${CssSizeVariables.sapWcrAnalyticalTableRowHeight})`,
8-
minHeight: '3rem'
8+
minHeight: '3rem',
99
},
1010
table: {
1111
position: 'relative',
1212
width: '100%',
1313
maxWidth: '100%',
14-
overflowX: 'auto'
14+
overflowX: 'auto',
1515
},
1616
tableHeaderRow: {
1717
boxShadow: 'none !important',
1818
height: CssSizeVariables.sapWcrAnalyticalTableRowHeight,
19-
position: 'relative'
19+
position: 'relative',
2020
},
2121
th: {
2222
backgroundColor: ThemingParameters.sapList_HeaderBackground,
@@ -31,55 +31,59 @@ const styles = {
3131
textAlign: 'start',
3232
boxSizing: 'border-box',
3333
'&:first-child': {
34-
borderLeft: `1px solid ${ThemingParameters.sapList_BorderColor}`
35-
}
34+
borderLeft: `1px solid ${ThemingParameters.sapList_BorderColor}`,
35+
},
3636
},
3737
tbody: {
3838
position: 'relative',
3939
zIndex: 0,
4040
backgroundColor: ThemingParameters.sapList_Background,
4141
overflowX: 'hidden !important',
42-
overflowY: 'auto !important'
42+
overflowY: 'auto !important',
4343
},
4444
alternateRowColor: {
45-
backgroundColor: ThemingParameters.sapList_HeaderBackground
45+
backgroundColor: ThemingParameters.sapList_HeaderBackground,
4646
},
4747
emptyRow: {},
4848
tr: {
4949
zIndex: 0,
5050
color: ThemingParameters.sapList_TextColor,
51+
boxSizing: 'border-box',
5152
'&[data-is-selected]': {
52-
backgroundColor: `${ThemingParameters.sapList_SelectionBackgroundColor} !important`
53+
backgroundColor: `${ThemingParameters.sapList_SelectionBackgroundColor} !important`,
54+
'& $tableCell': {
55+
borderBottom: `1px solid ${ThemingParameters.sapList_SelectionBorderColor}`,
56+
},
5357
},
5458
'&[data-is-selected]:hover': {
55-
backgroundColor: `${ThemingParameters.sapList_Hover_SelectionBackground} !important`
56-
}
59+
backgroundColor: `${ThemingParameters.sapList_Hover_SelectionBackground} !important`,
60+
},
5761
},
5862
tableGroupHeader: {
5963
'&$tr': {
6064
backgroundColor: `${ThemingParameters.sapList_TableGroupHeaderBackground} !important`,
6165
border: `1px solid ${ThemingParameters.sapList_TableGroupHeaderBorderColor}`,
6266
color: ThemingParameters.sapList_TextColor,
6367
'& $tableCell': {
64-
borderRight: 'none'
65-
}
66-
}
68+
borderRight: 'none',
69+
},
70+
},
6771
},
6872
selectable: {
6973
'& $tr:hover:not($emptyRow)': {
7074
backgroundColor: ThemingParameters.sapList_Hover_Background,
7175
'&:not($selectionModeRowSelector)': {
72-
cursor: 'pointer'
73-
}
76+
cursor: 'pointer',
77+
},
7478
},
7579
'& $tr:active:not([data-is-selected]):not($tableGroupHeader):not($emptyRow):not($selectionModeRowSelector)': {
7680
backgroundColor: ThemingParameters.sapList_Active_Background,
7781
'& $tableCell': {
7882
borderRight: `1px solid ${ThemingParameters.sapList_Active_Background}`,
7983
color: `${ThemingParameters.sapList_Active_TextColor}`,
80-
'--sapTextColor': ThemingParameters.sapList_Active_TextColor
81-
}
82-
}
84+
'--sapTextColor': ThemingParameters.sapList_Active_TextColor,
85+
},
86+
},
8387
},
8488
selectionModeRowSelector: {},
8589
tableCell: {
@@ -93,7 +97,7 @@ const styles = {
9397
display: 'flex',
9498
padding: '0 0.5rem',
9599
'&:first-child': {
96-
borderLeft: `1px solid ${ThemingParameters.sapList_BorderColor}`
100+
borderLeft: `1px solid ${ThemingParameters.sapList_BorderColor}`,
97101
},
98102
overflow: 'hidden',
99103
position: 'relative',
@@ -102,8 +106,8 @@ const styles = {
102106
alignItems: 'center',
103107
'&:focus': {
104108
outlineOffset: '-2px',
105-
outline: `1px dotted ${ThemingParameters.sapContent_FocusColor}`
106-
}
109+
outline: `1px dotted ${ThemingParameters.sapContent_FocusColor}`,
110+
},
107111
},
108112
noDataContainer: {
109113
display: 'flex',
@@ -117,13 +121,13 @@ const styles = {
117121
fontFamily: ThemingParameters.sapFontFamily,
118122
fontSize: ThemingParameters.sapFontSize,
119123
fontWeight: 'normal',
120-
borderBottom: `1px solid ${ThemingParameters.sapList_BorderColor}`
124+
borderBottom: `1px solid ${ThemingParameters.sapList_BorderColor}`,
121125
},
122126
modifiedRowHeight: {
123127
'& $tableCell': {
124-
height: (props) => `${props.rowHeight}px`
125-
}
126-
}
128+
height: (props) => `${props.rowHeight}px`,
129+
},
130+
},
127131
};
128132

129133
export default styles;

0 commit comments

Comments
 (0)