Skip to content

Commit ea6d4d7

Browse files
authored
fix(MessageView & MessageItem): update to latest design specs (#5298)
1 parent 306b412 commit ea6d4d7

File tree

3 files changed

+12
-9
lines changed

3 files changed

+12
-9
lines changed

packages/base/src/styling/CssSizeVariables.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ export enum CssSizeVariablesNames {
1818
ui5WcrFormGroupTitleHeight = '--_ui5wcr-FormGroupTitleHeight',
1919
ui5WcrMessageViewListItemHeightSingle = '--_ui5wcr-MessageViewListItemHeightSingle',
2020
ui5WcrMessageViewListItemHeightByLine = '--_ui5wcr-MessageViewListItemHeightByLine',
21+
ui5WcrMessageItemTitleFontSize = '--_ui5wcr-MessageItemTitleFontSize',
2122
ui5WcrSplitterSize = '--_ui5wcr-SplitterSize',
2223
ui5WcrDialogHeaderHeight = '--_ui5wcr-DialogHeaderHeight',
2324
ui5WcrDialogSubHeaderHeight = '--_ui5wcr-DialogSubHeaderHeight',
@@ -51,6 +52,7 @@ export const CozySizes = {
5152
[CssSizeVariablesNames.ui5WcrFormGroupTitleHeight]: `2.75rem`,
5253
[CssSizeVariablesNames.ui5WcrMessageViewListItemHeightSingle]: `2.75rem`,
5354
[CssSizeVariablesNames.ui5WcrMessageViewListItemHeightByLine]: `3.325rem`,
55+
[CssSizeVariablesNames.ui5WcrMessageItemTitleFontSize]: ThemingParameters.sapFontHeader5Size,
5456
[CssSizeVariablesNames.ui5WcrSplitterSize]: `1rem`,
5557
[CssSizeVariablesNames.ui5WcrDialogHeaderHeight]: '2.75rem',
5658
[CssSizeVariablesNames.ui5WcrDialogSubHeaderHeight]: '3rem',
@@ -75,6 +77,7 @@ export const CompactSizes = {
7577
[CssSizeVariablesNames.ui5WcrFormGroupTitleHeight]: `2rem`,
7678
[CssSizeVariablesNames.ui5WcrMessageViewListItemHeightSingle]: `2rem`,
7779
[CssSizeVariablesNames.ui5WcrMessageViewListItemHeightByLine]: `3.25rem`,
80+
[CssSizeVariablesNames.ui5WcrMessageItemTitleFontSize]: ThemingParameters.sapFontHeader6Size,
7881
[CssSizeVariablesNames.ui5WcrDialogHeaderHeight]: '2.5rem',
7982
[CssSizeVariablesNames.ui5WcrDialogSubHeaderHeight]: '2.25rem',
8083
[CssSizeVariablesNames.ui5WcrElementHeight]: ThemingParameters.sapElement_Compact_Height

packages/main/src/components/MessageView/MessageItem.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -62,14 +62,14 @@ const useStyles = createUseStyles(
6262
width: '100%',
6363
maxWidth: '100%',
6464
overflow: 'hidden',
65-
paddingRight: '1rem',
65+
paddingInlineEnd: '1rem',
6666
boxSizing: 'border-box'
6767
},
6868
withSubtitle: {
6969
height: CssSizeVariables.ui5WcrMessageViewListItemHeightByLine
7070
},
7171
withChildren: {
72-
paddingRight: '0rem'
72+
paddingInlineEnd: '0rem'
7373
},
7474
iconContainer: {
7575
width: '3rem',
@@ -85,15 +85,15 @@ const useStyles = createUseStyles(
8585
},
8686
title: {
8787
fontFamily: ThemingParameters.sapFontHeaderFamily,
88-
fontSize: ThemingParameters.sapFontHeader6Size,
88+
fontSize: CssSizeVariables.ui5WcrMessageItemTitleFontSize,
8989
color: ThemingParameters.sapGroup_TitleTextColor,
9090
maxWidth: '100%',
9191
whiteSpace: 'nowrap',
9292
overflow: 'hidden',
9393
textOverflow: 'ellipsis',
9494
flex: '1 1 auto',
9595
'& + $subtitle': {
96-
marginTop: '0.25rem',
96+
marginBlockStart: '0.25rem',
9797
cursor: 'inherit'
9898
}
9999
},
@@ -102,7 +102,7 @@ const useStyles = createUseStyles(
102102
color: ThemingParameters.sapContent_MarkerTextColor,
103103
fontFamily: ThemingParameters.sapFontFamily,
104104
fontSize: ThemingParameters.sapFontSize,
105-
paddingLeft: '1rem',
105+
paddingInlineStart: '1rem',
106106
flex: 'none'
107107
},
108108
navigation: {

packages/main/src/components/MessageView/index.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ const useStyles = createUseStyles(
113113
'&[data-key="Error"]:not([pressed])': { color: ThemingParameters.sapNegativeElementColor },
114114
'&[data-key="Warning"]:not([pressed])': { color: ThemingParameters.sapCriticalElementColor },
115115
'&[data-key="Success"]:not([pressed])': { color: ThemingParameters.sapPositiveElementColor },
116-
'&[data-key="Information"]:not([pressed])': { color: ThemingParameters.sapNeutralElementColor }
116+
'&[data-key="Information"]:not([pressed])': { color: ThemingParameters.sapInformativeElementColor }
117117
},
118118
detailsContainer: {
119119
padding: '1rem'
@@ -124,18 +124,18 @@ const useStyles = createUseStyles(
124124
'&[data-type="Error"]': { color: ThemingParameters.sapNegativeElementColor },
125125
'&[data-type="Warning"]': { color: ThemingParameters.sapCriticalElementColor },
126126
'&[data-type="Success"]': { color: ThemingParameters.sapPositiveElementColor },
127-
'&[data-type="Information"],&[data-type="None"]': { color: ThemingParameters.sapNeutralElementColor }
127+
'&[data-type="Information"],&[data-type="None"]': { color: ThemingParameters.sapInformativeElementColor }
128128
},
129129
detailsTextContainer: { overflow: 'hidden' },
130130
detailsTitle: {
131-
marginBottom: '1rem'
131+
marginBlockEnd: '1rem'
132132
},
133133
detailsText: {
134134
fontFamily: ThemingParameters.sapFontFamily,
135135
fontSize: ThemingParameters.sapFontSize,
136136
lineHeight: 1.4,
137137
color: ThemingParameters.sapTextColor,
138-
marginBottom: '1rem'
138+
marginBlockEnd: '1rem'
139139
}
140140
},
141141
{ name: 'MessageView' }

0 commit comments

Comments
 (0)