Skip to content

Commit f4c4ebb

Browse files
fix(ObjectPageTitle): prevent styling race condition when using static css bundle (#6115)
1 parent 4984a94 commit f4c4ebb

File tree

3 files changed

+10
-6
lines changed

3 files changed

+10
-6
lines changed

.husky/pre-commit

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
lint-staged
1+
yarn run lint-staged

packages/main/src/components/ObjectPageTitle/ObjectPageTitle.module.css

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,6 @@
44
min-height: 3rem;
55
padding-block-start: 0.5rem;
66
padding-block-end: 0.5rem;
7-
display: flex;
8-
flex-direction: column;
9-
justify-content: space-between;
107
position: sticky;
118
inset-block-start: 0;
129
z-index: 2;

packages/main/src/components/ObjectPageTitle/index.tsx

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { debounce, Device, useStylesheet, useSyncRef } from '@ui5/webcomponents-
44
import { clsx } from 'clsx';
55
import type { ReactElement, ReactNode } from 'react';
66
import { cloneElement, forwardRef, isValidElement, useEffect, useRef, useState } from 'react';
7-
import { FlexBoxAlignItems, FlexBoxJustifyContent } from '../../enums/index.js';
7+
import { FlexBoxAlignItems, FlexBoxDirection, FlexBoxJustifyContent } from '../../enums/index.js';
88
import { stopPropagation } from '../../internal/stopPropagation.js';
99
import type { CommonProps } from '../../types/index.js';
1010
import type { ToolbarDomRef } from '../../webComponents/index.js';
@@ -198,7 +198,14 @@ const ObjectPageTitle = forwardRef<HTMLDivElement, ObjectPageTitlePropTypes>((pr
198198
}, []);
199199

200200
return (
201-
<FlexBox className={containerClasses} ref={componentRef} data-component-name="ObjectPageTitle" {...rest}>
201+
<FlexBox
202+
className={containerClasses}
203+
ref={componentRef}
204+
data-component-name="ObjectPageTitle"
205+
direction={FlexBoxDirection.Column}
206+
justifyContent={FlexBoxJustifyContent.SpaceBetween}
207+
{...rest}
208+
>
202209
<span
203210
className={classNames.clickArea}
204211
onClick={onHeaderClick}

0 commit comments

Comments
 (0)