Skip to content

Commit f841ead

Browse files
Lukas742MarcusNotheis
authored andcommitted
fix(AnalyticalTable): BusyIndicator is displayed when loading prop is true (#61)
1 parent 4728c74 commit f841ead

File tree

2 files changed

+9
-8
lines changed

2 files changed

+9
-8
lines changed

packages/main/__karma_snapshots__/AnalyticalTable.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -577,9 +577,9 @@
577577
</WithStyles(Pagination)>
578578
</div>
579579
<CustomLoadingComponent loading={false} loadingText="Loading...">
580-
<div className="-loading">
581-
<BusyIndicator size="Large">
582-
<ui5-busyindicator size="Large" class="" />
580+
<div className="-loading" style={{...}}>
581+
<BusyIndicator size="Medium" active={true} style={{...}}>
582+
<ui5-busyindicator active={true} size="Medium" style={{...}} class="" />
583583
</BusyIndicator>
584584
</div>
585585
</CustomLoadingComponent>
@@ -1185,9 +1185,9 @@
11851185
</WithStyles(Pagination)>
11861186
</div>
11871187
<CustomLoadingComponent loading={false} loadingText="Loading...">
1188-
<div className="-loading">
1189-
<BusyIndicator size="Large">
1190-
<ui5-busyindicator size="Large" class="" />
1188+
<div className="-loading" style={{...}}>
1189+
<BusyIndicator size="Medium" active={true} style={{...}}>
1190+
<ui5-busyindicator active={true} size="Medium" style={{...}} class="" />
11911191
</BusyIndicator>
11921192
</div>
11931193
</CustomLoadingComponent>

packages/main/src/components/AnalyticalTable/index.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,15 +12,16 @@ import { ColumnHeader } from './columnHeader';
1212
import { Pagination } from './pagination';
1313
import { TitleBar } from './titleBar';
1414
import { FilterEntry } from './types/FilterEntry';
15+
import { BusyIndicatorType } from '../../lib/BusyIndicatorType';
1516

1617
const CustomLoadingComponent = (props) => {
1718
let className = '-loading';
1819
if (props.loading) {
1920
className += ' -active';
2021
}
2122
return (
22-
<div className={className}>
23-
<BusyIndicator />
23+
<div className={className} style={{ display: 'flex', justifyContent: 'center', alignItems: 'center' }}>
24+
<BusyIndicator size={BusyIndicatorType.Medium} active style={{ backgroundColor: 'transparent' }} />
2425
</div>
2526
);
2627
};

0 commit comments

Comments
 (0)