Skip to content

Commit fe98dcb

Browse files
fix(AnalyticalTable): Loading Placeholder now respects show prop of columns (#224)
1 parent 5b78651 commit fe98dcb

File tree

16 files changed

+357
-236
lines changed

16 files changed

+357
-236
lines changed

babel.config.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
11
module.exports = {
2-
presets: ['babel-preset-react-app']
2+
presets: ['babel-preset-react-app'],
3+
plugins: ['@babel/plugin-proposal-nullish-coalescing-operator']
34
};

package.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
},
2929
"devDependencies": {
3030
"@babel/core": "^7.4.4",
31+
"@babel/plugin-proposal-nullish-coalescing-operator": "^7.4.4",
3132
"@storybook/storybook-deployer": "^2.8.1",
3233
"@types/enzyme": "^3.9.3",
3334
"@types/hoist-non-react-statics": "^3.3.1",
@@ -76,6 +77,7 @@
7677
"ncp": "^2.0.0",
7778
"npm-run-all": "^4.1.5",
7879
"ora": "^3.4.0",
80+
"prettier": "^1.19.1",
7981
"puppeteer": "^1.15.0",
8082
"qs": "^6.7.0",
8183
"react": "^16.8.6",

packages/main/src/components/AnalyticalTable/AnayticalTable.jss.ts

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -76,13 +76,6 @@ const styles = ({ parameters }: JSSTheme) => ({
7676
}
7777
}
7878
},
79-
tableGroupExpandCollapseIcon: {
80-
color: parameters.sapUiContentIconColor,
81-
height: '0.75rem',
82-
width: '0.75rem',
83-
padding: '0.625rem',
84-
display: 'block'
85-
},
8679
selectable: {},
8780
selectedRow: {},
8881
tableCell: {
@@ -99,11 +92,8 @@ const styles = ({ parameters }: JSSTheme) => ({
9992
borderLeft: `1px solid ${parameters.sapUiListVerticalBorderColor}`
10093
},
10194
overflow: 'hidden',
102-
position: 'relative'
103-
},
104-
tableCellContent: {
95+
position: 'relative',
10596
textOverflow: 'ellipsis',
106-
overflow: 'hidden',
10797
whiteSpace: 'nowrap',
10898
alignItems: 'center'
10999
},
@@ -121,7 +111,6 @@ const styles = ({ parameters }: JSSTheme) => ({
121111
fontWeight: 'normal',
122112
borderBottom: `1px solid ${parameters.sapUiListBorderColor}`
123113
},
124-
125114
compactSize: {
126115
'&$tableContainer': {
127116
height: 'calc(100% - 2rem)'

0 commit comments

Comments
 (0)