Skip to content

fix(AnalyticalTable): Loading Placeholder now respects show prop of columns #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 15, 2019

Conversation

MarcusNotheis
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Nov 13, 2019

Deploy preview for ui5-webcomponents-react ready!

Built with commit 4478cf6

https://deploy-preview-224--ui5-webcomponents-react.netlify.com

@codecov-io
Copy link

Codecov Report

Merging #224 into master will decrease coverage by 0.49%.
The diff coverage is 25.53%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #224     +/-   ##
=========================================
- Coverage   74.14%   73.64%   -0.5%     
=========================================
  Files         159      162      +3     
  Lines        3724     3730      +6     
  Branches      670      669      -1     
=========================================
- Hits         2761     2747     -14     
- Misses        735      759     +24     
+ Partials      228      224      -4
Impacted Files Coverage Δ
...mponents/AnalyticalTable/defaults/Column/index.tsx 80% <ø> (ø) ⬆️
...ages/main/src/components/AnalyticalTable/index.tsx 73.68% <100%> (+0.46%) ⬆️
.../AnalyticalTable/defaults/Column/RepeatedValue.tsx 100% <100%> (ø)
...onents/AnalyticalTable/defaults/Column/Grouped.tsx 25% <25%> (ø)
...omponents/AnalyticalTable/defaults/Column/Cell.tsx 40% <40%> (ø)
...AnalyticalTable/virtualization/VirtualTableRow.tsx 65.21% <40%> (-16.04%) ⬇️
...nts/AnalyticalTable/defaults/Column/Expandable.tsx 9.09% <9.09%> (ø)
...onents/AnalyticalTable/hooks/useToggleRowExpand.ts 27.27% <0%> (-9.1%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b78651...4478cf6. Read the comment docs.

@MarcusNotheis MarcusNotheis merged commit fe98dcb into master Nov 15, 2019
@MarcusNotheis MarcusNotheis deleted the fix/table-loading-placeholder branch November 15, 2019 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants