Skip to content

feat(AnalyticalTable): Upgrade react-table to beta.20 #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 3, 2019

Conversation

Lukas742
Copy link
Contributor

@Lukas742 Lukas742 commented Dec 3, 2019

Upgraded react-table to beta.20, removed setState, added reducer

Thank you for your contribution! 👏

To get it merged faster, kindly review the checklist below:

Pull Request Checklist

@netlify
Copy link

netlify bot commented Dec 3, 2019

Deploy preview for ui5-webcomponents-react ready!

Built with commit b834116

https://deploy-preview-237--ui5-webcomponents-react.netlify.com

@netlify
Copy link

netlify bot commented Dec 3, 2019

Deploy preview for ui5-webcomponents-react ready!

Built with commit 3ba5cfc

https://deploy-preview-237--ui5-webcomponents-react.netlify.com

@codecov-io
Copy link

codecov-io commented Dec 3, 2019

Codecov Report

Merging #237 into master will increase coverage by 0.05%.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #237      +/-   ##
=========================================
+ Coverage   72.25%   72.3%   +0.05%     
=========================================
  Files         160     161       +1     
  Lines        3532    3535       +3     
  Branches      615     616       +1     
=========================================
+ Hits         2552    2556       +4     
+ Misses        756     755       -1     
  Partials      224     224
Impacted Files Coverage Δ
...components/AnalyticalTable/tableReducer/reducer.ts 100% <100%> (ø)
...ages/main/src/components/AnalyticalTable/index.tsx 75% <66.66%> (+0.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dce81ad...3ba5cfc. Read the comment docs.

@MarcusNotheis MarcusNotheis merged commit 530917c into master Dec 3, 2019
@MarcusNotheis MarcusNotheis deleted the feature/AnalyticalTable branch December 3, 2019 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants