refactor(ThemeProvider): Remove custom Theme Injection #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove custom theme injection on Theme Provider as all required CSS variables are now injected by the UI5 Web Components. BREAKING CHANGE: Removed prop `noInjectThemeProperties` as this is now handled by the UI5 Web Components
|
Deploy preview for ui5-webcomponents-react ready! Built with commit b18e7d3 https://deploy-preview-241--ui5-webcomponents-react.netlify.com |
vbersch
approved these changes
Dec 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove custom theme injection on Theme Provider as all required CSS variables are now injected by the UI5 Web Components.
BREAKING CHANGE: Removed prop
noInjectThemePropertiesas this is now handled by the UI5 Web Components