Skip to content

feat(ObjectPage): Introduce Breadcrumbs and key infos #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 20, 2019
Merged

feat(ObjectPage): Introduce Breadcrumbs and key infos #246

merged 9 commits into from
Dec 20, 2019

Conversation

clemai
Copy link
Contributor

@clemai clemai commented Dec 10, 2019

  • Add Breadcrumbs above object title, if given.
  • Add key Info area.
  • Hide header content area, if renderHeaderContent is not given.
  • Fix lost title/subtitle issue, when switching from collapsed header to expanded header via expand button.

@netlify
Copy link

netlify bot commented Dec 10, 2019

Deploy preview for ui5-webcomponents-react ready!

Built with commit 361515f

https://deploy-preview-246--ui5-webcomponents-react.netlify.com

@codecov-io
Copy link

codecov-io commented Dec 12, 2019

Codecov Report

Merging #246 into master will increase coverage by 0.05%.
The diff coverage is 56.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #246      +/-   ##
==========================================
+ Coverage   73.46%   73.52%   +0.05%     
==========================================
  Files         160      160              
  Lines        3494     3498       +4     
  Branches      603      607       +4     
==========================================
+ Hits         2567     2572       +5     
- Misses        721      723       +2     
+ Partials      206      203       -3
Impacted Files Coverage Δ
packages/main/src/components/ObjectPage/index.tsx 44.66% <56.25%> (+1.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bd56bc...361515f. Read the comment docs.

@clemai clemai changed the title wip(ObjectPage): Introduce Breadcrumbs and key Infos area feat(ObjectPage): Introduce Breadcrumbs and key infos Dec 12, 2019
@clemai clemai requested a review from vbersch December 12, 2019 12:21
Copy link
Contributor

@vbersch vbersch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • render functions for breadcrumbs and keyinfos
  • first header content element has to be displayed under title/subtitle
  • collapse/expand twice -> duplicate display of header(title, subtitle + keyinfos)

@clemai clemai requested a review from vbersch December 13, 2019 14:07
@clemai clemai requested a review from vbersch December 20, 2019 07:29
@vbersch vbersch merged commit 6f44a72 into SAP:master Dec 20, 2019
@clemai clemai deleted the feat/object-page branch December 20, 2019 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants