Skip to content

Dialog: stretch is set to true, but the content of Dialog is not full stretched #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gnseo opened this issue Jan 23, 2020 · 4 comments
Closed

Comments

@gnseo
Copy link
Contributor

gnseo commented Jan 23, 2020

Describe the bug
Stretch is set to true, but the content of Dialog is not full stretched

To Reproduce
Installed version 0.7.1 of @ui5/web-components-react

Expected behavior
The content of Dialog should be full stretched.

@gnseo gnseo added the bug label Jan 23, 2020
@MarcusNotheis
Copy link
Contributor

Hi @iamuan
it looks like as it is intended that the Dialog is only streched to 90% of viewport width according to the UI5 Web Components Documentation:

strech: Determines whether the ui5-dialog should be stretched to fullscreen.
Note: The ui5-dialog will be stretched to aproximetly 90% of the viewport

@MapTo0: Do you know why it was implemented this way?

@gnseo
Copy link
Contributor Author

gnseo commented Jan 23, 2020

@MarcusNotheis The 90% is good since this width is set for dialog container. What I mentioned was content of dialog which is div element has class name "ui5-popup-content". I update its style on debugging tool, and then the Input and Table in dialog was full sized. (The Table's width is calculated by resizing its parent element, so after update the style in debugging tool, I had to trigger some event to update state to re-render the Table.)

Please see the screenshot.
Screen Shot 2020-01-23 at 6 54 26 PM

Screen Shot 2020-01-23 at 6 51 29 PM

@MarcusNotheis
Copy link
Contributor

Hi @iamuan
sorry, I didn't see the content part of your issue.
Unfortunately, there is not much we can do to fix this issue as this is coming from the underlying UI5 Web Components - I saw you already commented the corresponding issue SAP/ui5-webcomponents#920 as well.

@gnseo
Copy link
Contributor Author

gnseo commented Jan 28, 2020

Thanks, @MarcusNotheis. I'm closing this issue and waiting from SAP/ui5-webcomponents#920.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants