Skip to content

fix(AnalyticalTable): fix minRows + loading behaviour #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 5, 2020
Merged

fix(AnalyticalTable): fix minRows + loading behaviour #304

merged 2 commits into from
Feb 5, 2020

Conversation

vbersch
Copy link
Contributor

@vbersch vbersch commented Feb 5, 2020

  • if the table doesn´t have data and loading is true, it now shows the Placeholder loading again
  • fixed weird looking table headers with scaleWidthMode Grow in loading state
  • table cell renderer is now not being called for empty rows which were inserted because of the minRows prop

@vbersch vbersch requested a review from Lukas742 February 5, 2020 12:07
@vbersch vbersch merged commit 253a0c8 into master Feb 5, 2020
@vbersch vbersch deleted the fix/table-minrows-loading branch February 5, 2020 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lukas742 Lukas742 Lukas742 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vbersch @Lukas742