Skip to content

fix(AnalyticalTable): Show selection column with select all in header #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 10, 2020

Conversation

MarcusNotheis
Copy link
Contributor

@MarcusNotheis MarcusNotheis commented Feb 10, 2020

For compliance with fiori specs, show an additional selection column as first column to show CheckBoxes and a CheckBox in the Header for selecting/deselecting all rows

You can hide this column by setting the noSelectionColumn prop on the table.

Closes #302

Copy link
Contributor

@vbersch vbersch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two things.

image

  1. Is that empty column on the left for SINGLE_SELECT there on purpose? Is that part of the specs?
  2. The additional column doesn´t seem to play well together with the new scaleWidthMode feature. The table should be stretching for the whole available width, but it doesn´t.

@MarcusNotheis
Copy link
Contributor Author

  1. Is that empty column on the left for SINGLE_SELECT there on purpose? Is that part of the specs?

Yes, that is by design (also compare the sap.ui.table.Table)

  1. The additional column doesn´t seem to play well together with the new scaleWidthMode feature. The table should be stretching for the whole available width, but it doesn´t.

I'll have look at that one

@MarcusNotheis MarcusNotheis merged commit b60842c into master Feb 10, 2020
@MarcusNotheis MarcusNotheis deleted the feat/analytical-table-select-all branch February 10, 2020 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Analytical Table: Checkbox selection (Select All)
2 participants