refactor(Popovers): Remove custom logic #408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove custom open / openBy logic from Dialog, Popover and Responsive Popover and use the plain UI5 Web Component. BREAKING CHANGE: **Dialog**: Remove property `open`. You can now open a dialog by attaching a ref to the dialog and call the method `open()`. BREAKING CHANGE: **Popover**: Removed props `openBy`, `openByStyle`, `open` and `propagateOpenByClickEvent`. For opening a popover after e.g. a button click attach a ref to the popover and use the button click hander for calling `.openBy(event.target)` on the popover ref. BREAKING CHANGE: **ResponsivePopover**: Removed props `openBy`, `openByStyle`, `open` and `propagateOpenByClickEvent`. For opening a responsive popover after e.g. a button click attach a ref to the responsive popover and use the Button click hander for calling `.open(event.target)` on the responsive popover ref.
Lukas742
requested changes
Apr 7, 2020
packages/main/src/webComponents/ResponsivePopover/ResponsivePopover.stories.tsx
Outdated
Show resolved
Hide resolved
Lukas742
requested changes
Apr 7, 2020
packages/main/src/webComponents/ResponsivePopover/ResponsivePopover.stories.tsx
Outdated
Show resolved
Hide resolved
…pover.stories.tsx Co-Authored-By: Lukas <[email protected]>
Co-Authored-By: Lukas <[email protected]>
…pover.stories.tsx Co-Authored-By: Lukas <[email protected]>
Lukas742
approved these changes
Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove custom open / openBy logic from Dialog, Popover and Responsive Popover and use the plain UI5 Web Component.
BREAKING CHANGE: Dialog: Remove property
open. You can now open a dialog by attaching a ref to the dialog and call the methodopen().BREAKING CHANGE: Popover: Removed props
openBy,openByStyle,openandpropagateOpenByClickEvent. For opening a popover after e.g. a button click attach a ref to the popover and use the button click hander for calling.openBy(event.target)on the popover ref.BREAKING CHANGE: ResponsivePopover: Removed props
openBy,openByStyle,openandpropagateOpenByClickEvent. For opening a responsive popover after e.g. a button click attach a ref to the responsive popover and use the Button click hander for calling.open(event.target)on the responsive popover ref.