Skip to content

fix(AnalyticalTable): fix scrollbar issue on column reorder & initial horizontal scrolling #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 8, 2020
Merged

fix(AnalyticalTable): fix scrollbar issue on column reorder & initial horizontal scrolling #413

merged 4 commits into from
Apr 8, 2020

Conversation

MarcusNotheis
Copy link
Contributor

No description provided.

@MarcusNotheis MarcusNotheis requested a review from vbersch April 8, 2020 07:08
@github-actions
Copy link

github-actions bot commented Apr 8, 2020

Coverage Status

Coverage remained the same at 67.381% when pulling 167c84a on fix/analytical-table-scrollbar-issue into c5fd469 on master.

@github-actions
Copy link

github-actions bot commented Apr 8, 2020 •
edited
Loading

Size Change: +6 B (0%)

Total Size: 218 kB

Filename Size Change
packages/main/lib/AnalyticalTable.js 15.4 kB +6 B (0%)
ℹ️ View Unchanged
Filename Size Change
packages/base/lib/createComponentStyles.js 206 B 0 B
packages/base/lib/CssSizeVariables.js 1.16 kB 0 B
packages/base/lib/Device.js 12.1 kB 0 B
packages/base/lib/Event.js 966 B 0 B
packages/base/lib/font72.js 447 B 0 B
packages/base/lib/HSLColor.js 2.62 kB 0 B
packages/base/lib/Logger.js 1.41 kB 0 B
packages/base/lib/Optional.js 1.48 kB 0 B
packages/base/lib/sap_fiori_3.js 6.69 kB 0 B
packages/base/lib/ScrollContext.js 232 B 0 B
packages/base/lib/Scroller.js 3.04 kB 0 B
packages/base/lib/ScrollLink.js 588 B 0 B
packages/base/lib/spacing.js 1.23 kB 0 B
packages/base/lib/StyleClassHelper.js 1.53 kB 0 B
packages/base/lib/ThemingParameters.js 3.4 kB 0 B
packages/base/lib/useConsolidatedRef.js 271 B 0 B
packages/base/lib/usePassThroughHtmlProps.js 765 B 0 B
packages/base/lib/useScrollElement.js 727 B 0 B
packages/base/lib/useViewportRange.js 816 B 0 B
packages/base/lib/Utils.js 1.12 kB 0 B
packages/charts/lib/BarChart.js 4.64 kB 0 B
packages/charts/lib/BarChartPlaceholder.js 403 B 0 B
packages/charts/lib/ColumnChart.js 4.77 kB 0 B
packages/charts/lib/ColumnChartPlaceholder.js 436 B 0 B
packages/charts/lib/DonutChart.js 3.13 kB 0 B
packages/charts/lib/initialize.js 1.58 kB 0 B
packages/charts/lib/LineChart.js 4.3 kB 0 B
packages/charts/lib/LineChartPlaceholder.js 450 B 0 B
packages/charts/lib/MicroBarChart.js 2.4 kB 0 B
packages/charts/lib/next/BarChart.js 5.15 kB 0 B
packages/charts/lib/next/ChartContainer.js 658 B 0 B
packages/charts/lib/next/ColumnChart.js 5.24 kB 0 B
packages/charts/lib/next/ComposedChart.js 6.31 kB 0 B
packages/charts/lib/next/DonutChart.js 1.98 kB 0 B
packages/charts/lib/next/LineChart.js 5.18 kB 0 B
packages/charts/lib/next/MicroBarChart.js 1.93 kB 0 B
packages/charts/lib/next/PieChart.js 1.84 kB 0 B
packages/charts/lib/next/RadarChart.js 3.81 kB 0 B
packages/charts/lib/next/RadialChart.js 1.19 kB 0 B
packages/charts/lib/PieChart.js 3.09 kB 0 B
packages/charts/lib/PieChartPlaceholder.js 363 B 0 B
packages/charts/lib/RadarChart.js 2.82 kB 0 B
packages/charts/lib/RadialChart.js 3.68 kB 0 B
packages/charts/lib/useLegendItemClick.js 391 B 0 B
packages/charts/lib/useResolveDataKeys.js 294 B 0 B
packages/charts/lib/withChartContainer.js 2.54 kB 0 B
packages/main/lib/ActionSheet.js 1.22 kB 0 B
packages/main/lib/AnalyticalCard.js 1.2 kB 0 B
packages/main/lib/AnalyticalCardHeader.js 2.93 kB 0 B
packages/main/lib/AnalyticalTableScrollMode.js 185 B 0 B
packages/main/lib/Avatar.js 405 B 0 B
packages/main/lib/AvatarBackgroundColor.js 219 B 0 B
packages/main/lib/AvatarFitType.js 151 B 0 B
packages/main/lib/AvatarShape.js 150 B 0 B
packages/main/lib/AvatarSize.js 155 B 0 B
packages/main/lib/Badge.js 303 B 0 B
packages/main/lib/Bar.js 1.32 kB 0 B
packages/main/lib/BarDesign.js 177 B 0 B
packages/main/lib/Breadcrumbs.js 707 B 0 B
packages/main/lib/BreadcrumbsSeparatorStyle.js 198 B 0 B
packages/main/lib/BusyIndicator.js 334 B 0 B
packages/main/lib/BusyIndicatorSize.js 167 B 0 B
packages/main/lib/Button.js 346 B 0 B
packages/main/lib/ButtonDesign.js 190 B 0 B
packages/main/lib/Calendar.js 309 B 0 B
packages/main/lib/CalendarType.js 212 B 0 B
packages/main/lib/Card.js 325 B 0 B
packages/main/lib/Carousel.js 373 B 0 B
packages/main/lib/CarouselArrowsPlacement.js 166 B 0 B
packages/main/lib/CheckBox.js 361 B 0 B
packages/main/lib/ComboBox.js 381 B 0 B
packages/main/lib/ComboBoxItem.js 304 B 0 B
packages/main/lib/ContentDensity.js 151 B 0 B
packages/main/lib/CurrentViewportRangeContext.js 133 B 0 B
packages/main/lib/CustomListItem.js 335 B 0 B
packages/main/lib/DatePicker.js 424 B 0 B
packages/main/lib/DeviationIndicator.js 160 B 0 B
packages/main/lib/Dialog.js 325 B 0 B
packages/main/lib/FileUploader.js 369 B 0 B
packages/main/lib/FilterBar.js 1.74 kB 0 B
packages/main/lib/FilterItem.js 1.53 kB 0 B
packages/main/lib/FilterType.js 170 B 0 B
packages/main/lib/FlexBox.js 1.08 kB 0 B
packages/main/lib/FlexBoxAlignItems.js 189 B 0 B
packages/main/lib/FlexBoxDirection.js 169 B 0 B
packages/main/lib/FlexBoxJustifyContent.js 194 B 0 B
packages/main/lib/FlexBoxWrap.js 154 B 0 B
packages/main/lib/Form.js 1.6 kB 0 B
packages/main/lib/FormGroup.js 776 B 0 B
packages/main/lib/FormItem.js 1.65 kB 0 B
packages/main/lib/GlobalStyleClasses.js 151 B 0 B
packages/main/lib/Grid.js 2.69 kB 0 B
packages/main/lib/GridPosition.js 2.69 kB 0 B
packages/main/lib/GroupHeaderListItem.js 314 B 0 B
packages/main/lib/Icon.js 320 B 0 B
packages/main/lib/Input.js 396 B 0 B
packages/main/lib/InputType.js 184 B 0 B
packages/main/lib/Label.js 326 B 0 B
packages/main/lib/Link.js 340 B 0 B
packages/main/lib/LinkDesign.js 191 B 0 B
packages/main/lib/List.js 382 B 0 B
packages/main/lib/ListItemTypes.js 160 B 0 B
packages/main/lib/ListMode.js 191 B 0 B
packages/main/lib/ListSeparators.js 186 B 0 B
packages/main/lib/Loader.js 1.91 kB 0 B
packages/main/lib/LoaderType.js 152 B 0 B
packages/main/lib/MessageBox.js 1.97 kB 0 B
packages/main/lib/MessageBoxActions.js 231 B 0 B
packages/main/lib/MessageBoxTypes.js 232 B 0 B
packages/main/lib/MessageStrip.js 352 B 0 B
packages/main/lib/MessageStripType.js 181 B 0 B
packages/main/lib/MultiComboBox.js 382 B 0 B
packages/main/lib/MultiComboBoxItem.js 320 B 0 B
packages/main/lib/Notification.js 3.98 kB 0 B
packages/main/lib/NotificationGroup.js 309 B 0 B
packages/main/lib/ObjectPage.js 9.78 kB 0 B
packages/main/lib/ObjectPageMode.js 159 B 0 B
packages/main/lib/ObjectPageSection.js 2.1 kB 0 B
packages/main/lib/ObjectPageSubSection.js 1.95 kB 0 B
packages/main/lib/ObjectStatus.js 1.18 kB 0 B
packages/main/lib/Option.js 301 B 0 B
packages/main/lib/Page.js 2.01 kB 0 B
packages/main/lib/PageBackgroundDesign.js 183 B 0 B
packages/main/lib/Panel.js 350 B 0 B
packages/main/lib/PanelAccessibleRoles.js 201 B 0 B
packages/main/lib/PlacementType.js 175 B 0 B
packages/main/lib/Popover.js 422 B 0 B
packages/main/lib/PopoverHorizontalAlign.js 181 B 0 B
packages/main/lib/PopoverPlacementType.js 172 B 0 B
packages/main/lib/PopoverVerticalAlign.js 204 B 0 B
packages/main/lib/Priority.js 163 B 0 B
packages/main/lib/ProductSwitch.js 298 B 0 B
packages/main/lib/ProductSwitchItem.js 339 B 0 B
packages/main/lib/ProgressIndicator.js 1.78 kB 0 B
packages/main/lib/RadioButton.js 365 B 0 B
packages/main/lib/ResponsivePopover.js 432 B 0 B
packages/main/lib/SegmentedButton.js 298 B 0 B
packages/main/lib/Select.js 335 B 0 B
packages/main/lib/SemanticColor.js 181 B 0 B
packages/main/lib/ShellBar.js 365 B 0 B
packages/main/lib/ShellBarItem.js 308 B 0 B
packages/main/lib/SideNavigation.js 1.78 kB 0 B
packages/main/lib/SideNavigationListItem.js 2.78 kB 0 B
packages/main/lib/SideNavigationOpenState.js 174 B 0 B
packages/main/lib/Size.js 151 B 0 B
packages/main/lib/Spinner.js 1.49 kB 0 B
packages/main/lib/StandardListItem.js 345 B 0 B
packages/main/lib/SuggestionItem.js 319 B 0 B
packages/main/lib/Switch.js 331 B 0 B
packages/main/lib/Tab.js 356 B 0 B
packages/main/lib/TabContainer.js 353 B 0 B
packages/main/lib/TabLayout.js 150 B 0 B
packages/main/lib/Table.js 331 B 0 B
packages/main/lib/TableCell.js 293 B 0 B
packages/main/lib/TableColumn.js 310 B 0 B
packages/main/lib/TablePlaceholder.js 1.11 kB 0 B
packages/main/lib/TableRow.js 292 B 0 B
packages/main/lib/TableScaleWidthMode.js 169 B 0 B
packages/main/lib/TableSelectionBehavior.js 178 B 0 B
packages/main/lib/TableSelectionMode.js 182 B 0 B
packages/main/lib/TabSeparator.js 295 B 0 B
packages/main/lib/Text.js 831 B 0 B
packages/main/lib/TextAlign.js 183 B 0 B
packages/main/lib/TextArea.js 383 B 0 B
packages/main/lib/ThemeProvider.js 5.19 kB 0 B
packages/main/lib/Themes.js 178 B 0 B
packages/main/lib/ThemingSupport.js 62 B 0 B
packages/main/lib/Timeline.js 291 B 0 B
packages/main/lib/TimelineItem.js 337 B 0 B
packages/main/lib/TimePicker.js 374 B 0 B
packages/main/lib/Title.js 323 B 0 B
packages/main/lib/TitleLevel.js 163 B 0 B
packages/main/lib/Toast.js 334 B 0 B
packages/main/lib/ToastPlacement.js 208 B 0 B
packages/main/lib/ToggleButton.js 358 B 0 B
packages/main/lib/Token.js 200 B 0 B
packages/main/lib/Tokenizer.js 203 B 0 B
packages/main/lib/ValueState.js 182 B 0 B
packages/main/lib/VariantManagement.js 2.47 kB 0 B
packages/main/lib/VerticalAlign.js 174 B 0 B
packages/main/lib/withWebComponent.js 2.23 kB 0 B

compressed-size-action

@MarcusNotheis MarcusNotheis merged commit 4665db7 into master Apr 8, 2020
@MarcusNotheis MarcusNotheis deleted the fix/analytical-table-scrollbar-issue branch April 8, 2020 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbersch vbersch vbersch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarcusNotheis @vbersch