Skip to content

feat(cypress-commands): add clearUi5Input to cypress commands #4980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 21, 2023
Merged

feat(cypress-commands): add clearUi5Input to cypress commands #4980

merged 2 commits into from
Aug 21, 2023

Conversation

AndrianStoikov
Copy link
Contributor

@AndrianStoikov AndrianStoikov commented Aug 18, 2023 •
edited
Loading

Thank you for your contribution! 👏

To get it merged faster, kindly review the checklist below:

Pull Request Checklist

@cla-assistant
Copy link

cla-assistant bot commented Aug 18, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

coveralls commented Aug 18, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5903540414

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.09%) to 87.898%
Files with Coverage Reduction New Missed Lines %
packages/main/src/components/Modals/index.tsx 1 72.65%
Totals Coverage Status
Change from base Build 5901663119: 0.09%
Covered Lines: 4968
Relevant Lines: 5652
💛 - Coveralls

@AndrianStoikov AndrianStoikov marked this pull request as ready for review August 21, 2023 08:39
Lukas742
Lukas742 approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@Lukas742 Lukas742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@Lukas742 Lukas742 merged commit 31772fd into SAP:main Aug 21, 2023
@AndrianStoikov AndrianStoikov deleted the feat/cypress_clear_ui5input branch August 21, 2023 11:06
@github-actions
Copy link

github-actions bot commented Sep 4, 2023

🎉 This PR is included in version v1.19.0 🎉

The release is available on v1.19.0

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lukas742 Lukas742 Lukas742 approved these changes

@MarcusNotheis MarcusNotheis Awaiting requested review from MarcusNotheis MarcusNotheis is a code owner

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndrianStoikov @coveralls @Lukas742