Skip to content

Filter Bar: Seeing Blank field for filter group items without labels when we click on Filters. #5058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
dhruvojha opened this issue Sep 12, 2023 · 3 comments
Closed
1 task done

Comments

@dhruvojha
Copy link

Is your feature request related to a problem?

When we have a filter that does not have a label, we see a blank field compared to seeing the filter itself in the previous versions, it is only after clicking on "Show Values", that we are able to see the placeholder text and the filter component.

Describe the solution you'd like

Show the placeholder texts or component when we click on Filter button itself so that Filter Group Items without label do not show blank, as was the case in previous UI5 versions.

Describe alternatives you've considered

Please advise if this is feasible, as the requested functionality is already there, just behind another button. Link to the sandbox is given below:

https://codesandbox.io/s/quirky-phoebe-j2x63r

Steps to reproduce the issue:

  1. Click on the Filter Button, a pop up opens showing all the filters.
  2. As you can see, the filter without a label shows a blank field, it is only after clicking on show values button can we see anything, this is problematic from a user's point of view.

Additional Context

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@Lukas742
Copy link
Contributor

Lukas742 commented Sep 12, 2023

Hi @dhruvojha

per design guidelines all filters should have a label, that's why it's not displaying a value there. Just rendering the placeholder as label is not feasible, because not all filters use a placeholder.

If you want to achieve the following design:

image

Then this will be possible with our next release. Currently the search input field is rendered in the header toolbar, which doesn't comply with the latest design specs, so we'll update it with this PR.

Does this work for you?

@dhruvojha
Copy link
Author

dhruvojha commented Sep 12, 2023

Hi @Lukas742, thanks for the update, will have to look into this, as we have not been using the search input for our own search field because of the exact limitation which you specified. Many thanks!

@Lukas742
Copy link
Contributor

Hi @dhruvojha

The updated position of the search field will be available with our next version.
I'm going to close this issue now, if you're still facing issues after updating, please let us know. We will then reopen the issue :)

@Lukas742 Lukas742 moved this from 🆕 New to 2023-Q3 in ui5-webcomponents-react Roadmap Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 2023-Q3
Development

No branches or pull requests

2 participants