Skip to content

fix(ObjectStatus): fix border issue of None variant of inverted ObjectStatus #5147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2023
Merged

fix(ObjectStatus): fix border issue of None variant of inverted ObjectStatus #5147

merged 1 commit into from
Oct 13, 2023

Conversation

2bno1
Copy link
Contributor

@2bno1 2bno1 commented Oct 13, 2023

Before change:
image

After change:
image

@cla-assistant
Copy link

cla-assistant bot commented Oct 13, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

coveralls commented Oct 13, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6503457926

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.657%
Totals Coverage Status
Change from base Build 6482187744: 0.0%
Covered Lines: 5085
Relevant Lines: 5801
💛 - Coveralls

Lukas742
Lukas742 approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@Lukas742 Lukas742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 🚢

@Lukas742 Lukas742 enabled auto-merge (squash) October 13, 2023 06:40
@Lukas742 Lukas742 merged commit c52fc80 into SAP:main Oct 13, 2023
@2bno1 2bno1 deleted the defect/object-status-border-issue branch October 13, 2023 07:16
@github-actions
Copy link

🎉 This PR is included in version v1.21.1 🎉

The release is available on v1.21.1

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lukas742 Lukas742 Lukas742 approved these changes

@MarcusNotheis MarcusNotheis Awaiting requested review from MarcusNotheis MarcusNotheis is a code owner

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@2bno1 @coveralls @Lukas742