Skip to content

fix(ThemeProvider): Only inject theme properties if they are not present #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2019

Conversation

MarcusNotheis
Copy link
Contributor

Every Theme Provider was injecting the fiori3 parameters into the document head. This caused some errors. Therefore we now inject new parameters only if they are not present yet.

@MarcusNotheis MarcusNotheis requested a review from vbersch July 10, 2019 15:16
@MarcusNotheis MarcusNotheis merged commit 3ec61d5 into master Jul 11, 2019
@MarcusNotheis MarcusNotheis deleted the fix/theme-properties-injection branch July 11, 2019 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants