-
Notifications
You must be signed in to change notification settings - Fork 103
feat(Text): replace with UI5 Web Component #5988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+200
−388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: the `Text` component has been replaced with the `ui5-text` web component, please visit our [Migration Guide](https://sap.github.io/ui5-webcomponents-react/main/?path=/docs/migration-guide--docs) for more details. BREAKING CHANGE: **ExpandableText**: the inherited props `hyphenated` and `emptyIndicator` from the `Text` have been removed. BREAKING CHANGE: **ExpandableText**: the `portalContainer` prop has been removed as it's not needed anymore
Pull Request Test Coverage Report for Build 9694475376Details
💛 - Coveralls |
Size Change: -2.29 kB (-0.57%) Total Size: 401 kB
ℹ️ View Unchanged
|
Pull Request Test Coverage Report for Build 9694525091Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9694975170Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9695597982Details
💛 - Coveralls |
Lukas742
requested changes
Jul 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Test Coverage Report for Build 9746522014Details
💛 - Coveralls |
Translation Delivery
Pull Request Test Coverage Report for Build 9746585158Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9746729703Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9746930067Details
💛 - Coveralls |
Lukas742
approved these changes
Jul 1, 2024
🎉 This PR is included in version v2.0.0-rc.0 🎉 The release is available on v2.0.0-rc.0 Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: the
Text
component has been replaced with theui5-text
web component, please visit our Migration Guide for more details.BREAKING CHANGE: ExpandableText: the inherited props
hyphenated
andemptyIndicator
from theText
have been removed.BREAKING CHANGE: ExpandableText: the
portalContainer
prop has been removed as it's not needed anymore