Skip to content

AnalyticalTable: Multiple a11y issues with the row expansion button in analytical tree table #6516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
fushizen opened this issue Oct 18, 2024 · 2 comments · Fixed by #6587
Closed
1 task done

Comments

@fushizen
Copy link

Describe the bug

Using axe devtools (a plugin used by the internal A11y team to check for issues) In the analytical tree table, the indicator to expand the tree table row has 2 critical a11y issues:

  1. On expanding the row, there is the issue ARIA attribute is not allowed: aria-expanded="true"

image

  1. The row expansion button has the issue Ensure buttons have discernible text

image

Isolated Example

https://sap.github.io/ui5-webcomponents-react/v1/?path=/story/data-display-analyticaltable--tree-table

Reproduction steps

  1. Go to the storybook for analytical table - tree table
  2. Open axe devtools in dev console
  3. Described issues are present

Expected Behaviour

Component to not have a11y issues detectable by the tool

Screenshots or Videos

image

image

UI5 Web Components for React Version

1.24.x

UI5 Web Components Version

1.24.x

Browser

Edge

Operating System

No response

Additional Context

No response

Relevant log output

No response

Organization

SAP

Declaration

  • I’m not disclosing any internal or sensitive information.
@Lukas742
Copy link
Contributor

Hi @fushizen

On expanding the row, there is the issue ARIA attribute is not allowed: aria-expanded="true"

This attribute is redundant, but since the button (inside the span) isn't focusable via keyboard navigation, it shouldn't affect users. Nonetheless, we'll remove it.

The row expansion button has the issue Ensure buttons have discernible text

The surrounding span has an aria-label that describes the interaction. Additionally, as the button isn't focusable via keyboard navigation, there shouldn't be an issue for users.


In general, please try to follow the Testing Accessibility guidelines and ensure that there's an actual accessibility concern present.

@ui5-webcomponents-react-bot
Copy link
Contributor

🎉 This issue has been resolved in version v2.4.0 🎉

The release is available on v2.4.0

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🆕 New
Development

Successfully merging a pull request may close this issue.

3 participants