Skip to content

[SF_ACC][SelectDialog]: The accessible name for the search field should be descriptive #6777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
i323808 opened this issue Dec 26, 2024 · 2 comments
Closed
1 task done

Comments

@i323808
Copy link

i323808 commented Dec 26, 2024

Describe the bug

Generic label - "search" is used as an accessible name.
Image

Isolated Example

No response

Reproduction steps

...

Expected Behaviour

Please provide a public prop to customize the accessible name of search field.

Screenshots or Videos

No response

UI5 Web Components for React Version

2.5.0

UI5 Web Components Version

2.5.0

Browser

Chrome

Operating System

No response

Additional Context

No response

Relevant log output

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@Lukas742
Copy link
Contributor

Lukas742 commented Jan 7, 2025

Hi @i323808

this PR will change the type of the input to "search". Is this sufficient for you, or do you need to customize the aria-label of the component?

If you need a way to customize it, then this request would need to go through the Inner Source process and be synchronised with the SAP Central Design team first. Please raise a BLI to the central design team and include the ticket number here for reference. Please contact me internally, if you require the current specifications or want to know the process of how to create BLIs for the central design team.

If you need this urgently, you could also adjust the label by accessing the element itself. Here you can find a basic StackBlitz example showing how this could be achieved: https://stackblitz.com/edit/ui5wcr-select-dialog-cihwxgdc?file=src%2FApp.tsx

@i323808
Copy link
Author

i323808 commented Jan 13, 2025

Hi @Lukas742 ,

Thanks for the reply. Closed this issue since the workaround is working.

Thanks,
Jane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 2025-Q1
Development

No branches or pull requests

2 participants