Skip to content

[SF][A11y][MessageView]: [initial focus is not set when expand the detail view] #7059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
tandan0813 opened this issue Mar 11, 2025 · 5 comments · Fixed by #7098
Closed
1 task done

[SF][A11y][MessageView]: [initial focus is not set when expand the detail view] #7059

tandan0813 opened this issue Mar 11, 2025 · 5 comments · Fixed by #7098

Comments

@tandan0813
Copy link

Describe the bug

  1. When the expandable info section is activated, the initial focus is not set. The user must press the Tab key to locate the focus indicator. And on returning back from the expanded section, focus is lost.

  2. No intimation on the presence of expandable section and neither activating keys are announced.

Please see the storybook: https://sap.github.io/ui5-webcomponents-react/v2/?path=/docs/user-feedback-messageview--docs

Isolated Example

https://sap.github.io/ui5-webcomponents-react/v2/?path=/docs/user-feedback-messageview--docs

Reproduction steps

...

Expected Behaviour

  1. Ensure focus is not lost and is visible when the section is expanded. 
  2. Ensure to provide screen reader announcements when sections are expanded. Also make sure the activation keys should be announced.

Screenshots or Videos

No response

UI5 Web Components for React Version

2.8.0

UI5 Web Components Version

2.8.0

Browser

Chrome

Operating System

No response

Additional Context

No response

Relevant log output

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@Lukas742
Copy link
Contributor

Hi @tandan0813

please extend your description with clear steps to reproduce the issue. Otherwise we're unfortunately not able to assist you.

@tandan0813
Copy link
Author

tandan0813 commented Mar 25, 2025

Hi @Lukas742
You can simply see the storybook of the MessageView:

Issue 1: When we enter the detail view of the MessageView through the MessageItem, the initial focus is not set. In the below sceniario, when we enter the detail view through link, the first focus should be on the Link. I can do that by adding focus in onItemSelect function. And when we returned to the MessageItem list view through back button, the focus is expected to set on the trigger element, I think it's a common requirement that would be implemented by MessageView component side.
Image

Image

Issue2: When a MessageItem is expandable, we should add some informational text for blind users to tell them they can open the detail view through press enter or something like that.

@Lukas742
Copy link
Contributor

Hi @tandan0813

thanks for the clarification. This PR will fix the first issue and also add an announcement ("Has Details") if details are available.
I didn't find specifications for a special announcement regarding the keys, so for this to be implemented this request would need to go through the Inner Source process and be synchronised with the SAP Central Design team first. In case this is a requirement for you, please open another issue for this and include the ticket number of the central design ticket there for reference.

@tandan0813
Copy link
Author

Hi @Lukas742 Thanks for your help!!

@ui5-webcomponents-react-bot
Copy link
Contributor

🎉 This issue has been resolved in version v2.9.0 🎉

The release is available on v2.9.0

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🆕 New
Development

Successfully merging a pull request may close this issue.

3 participants