Skip to content

Toolbar: When design is Solid, background color should not be transparent #7220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
gnseo opened this issue Apr 11, 2025 · 1 comment · Fixed by #7221
Closed
1 task done

Toolbar: When design is Solid, background color should not be transparent #7220

gnseo opened this issue Apr 11, 2025 · 1 comment · Fixed by #7221
Labels

Comments

@gnseo
Copy link
Contributor

gnseo commented Apr 11, 2025

Describe the bug

The background color for Solid design would be same as "sapBackgroundColor", since the "sapToolbar_Background" is always transparent.
As of now, design property does not affect the actual design, it always is "Transparent".

Isolated Example

No response

Reproduction steps

Expected Behaviour

I think we should replace "sapToolbar_Background" with "sapBackgroundColor" when className is "solid".

.solid {
background-color: var(--sapToolbar_Background);
}

Screenshots or Videos

No response

UI5 Web Components for React Version

v2.8.1

UI5 Web Components Version

v2.8.0

Browser

Chrome

Operating System

MacOS 15.4 (24E248)

Additional Context

No response

Relevant log output

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@ui5-webcomponents-react-bot
Copy link
Contributor

🎉 This issue has been resolved in version v2.9.2 🎉

The release is available on v2.9.2

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🆕 New
Development

Successfully merging a pull request may close this issue.

2 participants