-
Notifications
You must be signed in to change notification settings - Fork 103
[FilterBar]: Adapt Filters dialog unusable when working with compat Table #7314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @Na1k just a quick update — we're actively working on this topic. Unfortunately, it's not straightforward, as ensuring the tag name changes at the right time is tricky, especially in dev-mode. We'll keep you posted once we have further updates. Is there a specific reason, why you can't update to the V2 table? |
Hi @Na1k we just released a snapshot that adds a new command to our This is the snapshot version: 0.0.0-8aacff3422 To test it:
Could you please try out the script and let us know if it solved the issue in your application or if you faced issues? Thanks in advance! Unfortunately, we didn't find a better way to enable this across different implementations and environments. |
Hi @Lukas742, Thanks for the update! I'll try it out first thing tomorrow morning and let you know. Adding a patch is not great, but might help us to migrate to v2 and the v2 Table afterwards.
The reason why we don't want to migrate to the v2 Table right now is simple. It's marked as |
Thanks @Na1k!
Understandable, but according to this comment, the table will become stable in Q2, so migrating should soon be possible :) |
@Lukas742 That's good news! I wasn't aware of that, thanks. I tried to get the application running with the patches you provided. First things first, the adapt filters dialog table now looks as expected. But the compat table does not display any rows. Instead, for each row to display the following error is thrown and displayed in the console:
get ariaLabelText() {
const isSelected = this.selected ? TableRow_1.i18nBundle.getText(LIST_ITEM_SELECTED) : TableRow_1.i18nBundle.getText(LIST_ITEM_NOT_SELECTED);
const isRowSelectable = this.isSingleSelect || this.isMultiSelect;
const ariaLabel = this.cells.map((cell, index) => {
const columText = this.getColumnTextByIdx(index);
const cellText = cell.cellContent.length ? this.getCellText(cell) : cell.ariaLabelEmptyCellText; <--- This where the error is thrown
return `${columText} ${cellText}`;
}).join(" ");
if (isRowSelectable) {
return `${ariaLabel}. ${this.forcedAriaPosition}. ${isSelected}`;
}
return `${ariaLabel}. ${this.forcedAriaPosition}`;
} In addition to that, there is a |
@Na1k Thank you for testing! I tried to reproduce the error but wasn't able to. Could you take a look at this StackBlitz example and let me know if I need to adjust something to trigger the error?
I removed it - good catch 👍 |
@Lukas742 The issue was sitting in front of the screen... I can confirm, that the patch solves the reported issue. Do you have an estimate when it will be included in an official release of the webcomponents-react-cli package so I can get rid of the snapshot version in the |
@Na1k Glad to hear! We roll out feature updates (minor version bumps) to the If you'd prefer to avoid using a snapshot version in your Let me know what works best for you! |
@Lukas742 Thanks a lot for your support on this. A pre-release version would be awesome. |
Script won't run. I will fix the issue and draft another release |
Hi @Na1k the pre-release is now available and working. The following versions have to be set (only applicable for packages you're using):
All other |
Hi @Lukas742 Thanks a lot! |
Describe the bug
When rendering a
FilterDialog
in a project that uses theTable
component of thewebcomponents-react-compat
package, the dialog content is malformed. I assume this is because theFilterBar
uses the (experimental) v2Table
under the hood, leading to conflicts.Did I miss anything? Is there any workaround?
Isolated Example
https://stackblitz.com/edit/github-z74gvby1?file=src%2FApp.tsx
Reproduction steps
Table
from the compat packageFilterBar
Expected Behaviour
The FilterBar dialog shows the content correctly, regardless of the used
Table
component that is used in the app.Screenshots or Videos
No response
UI5 Web Components for React Version
2.9.0
UI5 Web Components Version
2.9.0
Browser
Chrome
Operating System
MacOS
Additional Context
No response
Relevant log output
Organization
No response
Declaration
The text was updated successfully, but these errors were encountered: