Skip to content

Commit 03c8447

Browse files
authored
fix(ui5-dialog): no longer gets clipped in short screen height in IE (#2429)
Fixes: #2243
1 parent efb0d8e commit 03c8447

File tree

2 files changed

+11
-3
lines changed

2 files changed

+11
-3
lines changed

packages/main/src/Dialog.js

+4
Original file line numberDiff line numberDiff line change
@@ -182,6 +182,10 @@ class Dialog extends Popup {
182182
return true;
183183
}
184184

185+
get _displayProp() {
186+
return "flex";
187+
}
188+
185189
get classes() {
186190
return {
187191
root: {

packages/main/src/Popup.js

+7-3
Original file line numberDiff line numberDiff line change
@@ -204,6 +204,10 @@ class Popup extends UI5Element {
204204
return staticAreaStyles;
205205
}
206206

207+
get _displayProp() {
208+
return "block";
209+
}
210+
207211
/**
208212
* Prevents the user from interacting with the content under the block layer
209213
*/
@@ -393,11 +397,11 @@ class Popup extends UI5Element {
393397
}
394398

395399
/**
396-
* Sets "block" display to the popup
400+
* Sets "block" display to the popup. The property can be overriden by derivatives of Popup.
397401
* @protected
398402
*/
399403
show() {
400-
this.style.display = "block";
404+
this.style.display = this._displayProp;
401405
}
402406

403407

@@ -417,7 +421,7 @@ class Popup extends UI5Element {
417421
}
418422

419423
/**
420-
* Implement this getter with relevant logic regarding the modality of the popup (f.e. based on a public property)
424+
* Implement this getter with relevant logic regarding the modality of the popup (e.g. based on a public property)
421425
*
422426
* @protected
423427
* @abstract

0 commit comments

Comments
 (0)