fix(ui5-datetime-picker): selecting only date value now works correct (#3294)

Author: tsanislavgatev

packages/main/src/DateTimePicker.js

@@ -322,6 +322,7 @@ class DateTimePicker extends DatePicker {
 			...this._previewValues,
 			calendarTimestamp: event.detail.timestamp,
 			calendarValue: event.detail.values[0],
+			timeSelectionValue: event.path[1].lastChild.value,
 		};
 	}
 
@@ -369,6 +370,7 @@ class DateTimePicker extends DatePicker {
 		}
 
 		this._focusInputAfterClose = true;
+		this._updateValueState();
 		this.closePicker();
 	}
 

packages/main/test/specs/DateTimePicker.spec.js

@@ -102,6 +102,35 @@ describe("DateTimePicker general interaction", () => {
 		assert.strictEqual(newValue.toUpperCase(), "14/04/2020, 01:02:03 AM", "The new date/time is correctly selected.");
 	});
 
+	it("tests selection of new date without changing the time section", () => {
+		const PREVIOUS_VALUE = "14/04/2020, 01:02:03 AM";
+		const dtPicker = browser.$("#dtSeconds");
+		// assert
+		const currentValue = dtPicker.shadow$("ui5-input").getValue();
+		assert.strictEqual(currentValue, PREVIOUS_VALUE,  "The initial date/time is correctly set.");
+
+		browser.keys("Tab");
+		browser.keys(["Shift", "Tab"]);
+		browser.keys("Backspace");
+		browser.keys("wrongtext");
+		browser.keys("Tab");
+
+		openPickerById("dtSeconds");
+		// act
+		const picker = getPicker("dtSeconds");
+		// select the next day (the right from the selected)
+		const selectedDay = picker.$("ui5-calendar").shadow$("ui5-daypicker").shadow$(".ui5-dp-item--now");
+		const timestamp = selectedDay.getAttribute("data-sap-timestamp");
+		const date = new Date(timestamp * 1000);
+		const selectedDate = `${date.getDate() < 10 ? "0" : ""}${date.getDate()}/${date.getMonth() + 1 < 10 ? "0" : ""}${date.getMonth() + 1}/${date.getFullYear()}`;
+		selectedDay.click();
+		picker.$("#ok").click();
+		// assert
+		const newValue = dtPicker.shadow$("ui5-input").getValue();
+		const result = newValue.indexOf(selectedDate) > -1;
+		assert.ok(result, "The new date/time is correctly selected.");
+	});
+
 	it("tests change event is fired on submit", () => {
 		// test submit from empty value to current date/time value
 		openPickerById("dt1");