Skip to content

Commit 0aac048

Browse files
fix(ui5-dialog): Fixed RTL mode (#3070)
Fixes: #3013
1 parent 00d0be4 commit 0aac048

File tree

2 files changed

+1
-6
lines changed

2 files changed

+1
-6
lines changed

packages/main/src/Popup.hbs

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
aria-modal="{{_ariaModal}}"
66
aria-label="{{_ariaLabel}}"
77
aria-labelledby="{{_ariaLabelledBy}}"
8-
dir="{{dir}}"
8+
dir="{{effectiveDir}}"
99
tabindex="-1"
1010
@keydown={{_onkeydown}}
1111
@focusout={{_onfocusout}}

packages/main/src/Popup.js

-5
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import { renderFinished } from "@ui5/webcomponents-base/dist/Render.js";
22
import litRender from "@ui5/webcomponents-base/dist/renderer/LitRenderer.js";
3-
import { getRTL } from "@ui5/webcomponents-base/dist/config/RTL.js";
43
import UI5Element from "@ui5/webcomponents-base/dist/UI5Element.js";
54
import { getFirstFocusableElement, getLastFocusableElement } from "@ui5/webcomponents-base/dist/util/FocusableElements.js";
65
import createStyleInHead from "@ui5/webcomponents-base/dist/util/createStyleInHead.js";
@@ -514,10 +513,6 @@ class Popup extends UI5Element {
514513
return this.shadowRoot.querySelector(".ui5-popup-root");
515514
}
516515

517-
get dir() {
518-
return getRTL() ? "rtl" : "ltr";
519-
}
520-
521516
get styles() {
522517
return {
523518
root: {},

0 commit comments

Comments
 (0)