Skip to content

Commit 0b1dc52

Browse files
authored
fix(ui5-panel): The expand/collapse button is not in the DOM when fixed (#1793)
1 parent 4359b9a commit 0b1dc52

File tree

2 files changed

+14
-18
lines changed

2 files changed

+14
-18
lines changed

packages/main/src/Panel.hbs

+13-13
Original file line numberDiff line numberDiff line change
@@ -14,18 +14,18 @@
1414
aria-expanded="{{accInfo.ariaExpanded}}"
1515
aria-controls="{{accInfo.ariaControls}}"
1616
>
17-
<div
18-
class="ui5-panel-header-button-root"
19-
>
20-
<ui5-button
21-
design="Transparent"
22-
class="ui5-panel-header-button {{classes.headerBtn}}"
23-
icon="navigation-right-arrow"
24-
?non-focusable="{{nonFocusableButton}}"
25-
@click="{{_toggleButtonClick}}"
26-
._buttonAccInfo="{{accInfo.button}}"
27-
></ui5-button>
28-
</div>
17+
{{#unless fixed}}
18+
<div class="ui5-panel-header-button-root">
19+
<ui5-button
20+
design="Transparent"
21+
class="ui5-panel-header-button {{classes.headerBtn}}"
22+
icon="navigation-right-arrow"
23+
?non-focusable="{{nonFocusableButton}}"
24+
@click="{{_toggleButtonClick}}"
25+
._buttonAccInfo="{{accInfo.button}}"
26+
></ui5-button>
27+
</div>
28+
{{/unless}}
2929

3030
{{#if _hasHeader}}
3131
<slot name="header"></slot>
@@ -44,4 +44,4 @@
4444
<div class="ui5-panel-content" id="{{_id}}-content" tabindex="-1" style="{{styles.content}}">
4545
<slot></slot>
4646
</div>
47-
</div>
47+
</div>

packages/main/src/themes/Panel.css

+1-5
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,6 @@
1212
border-bottom: 1px solid var(--sapGroup_TitleBorderColor);
1313
}
1414

15-
:host([fixed]) .ui5-panel-header-button-root {
16-
display: none;
17-
}
18-
1915
:host([fixed]) .ui5-panel-header {
2016
padding-left: 1rem;
2117
}
@@ -81,4 +77,4 @@
8177
flex-shrink: 0;
8278
width: var(--_ui5_panel_button_root_width);
8379
margin-right: .25rem;
84-
}
80+
}

0 commit comments

Comments
 (0)