Skip to content

Commit 0cef140

Browse files
authoredMay 18, 2020
fix(framework): allow for empty theme files (#1639)
1 parent 04b44b4 commit 0cef140

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed
 

‎packages/base/src/asset-registries/Themes.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ const registerThemeProperties = (packageName, themeName, style) => {
3131
if (style._) {
3232
// JSON object like ({"_": ":root"})
3333
themeStyles.set(`${packageName}_${themeName}`, style._);
34-
} else if (style.includes(":root")) {
35-
// pure string
34+
} else if (style.includes(":root") || style === "") {
35+
// pure string, including empty string
3636
themeStyles.set(`${packageName}_${themeName}`, style);
3737
} else {
3838
// url for fetching
@@ -44,7 +44,7 @@ const registerThemeProperties = (packageName, themeName, style) => {
4444

4545
const getThemeProperties = async (packageName, themeName) => {
4646
const style = themeStyles.get(`${packageName}_${themeName}`);
47-
if (style) {
47+
if (style !== undefined) { // it's valid for style to be an empty string
4848
return style;
4949
}
5050

0 commit comments

Comments
 (0)
Please sign in to comment.